Export an API to indicate when lsp4mp has started #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning from activate when lsp4mp has started, return before it has started. This allows extensions that depend on vscode-microprofile to begin activating before lsp4mp has fully started. Return an API that provides a promise which resolves once lsp4mp has started, so that extensions that need to interact with lsp4mp can wait until it is ready. Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
to datho7561/vscode-quarkus
that referenced
this pull request
Jun 28, 2021
See redhat-developer/vscode-microprofile#58 Consume the API provided by vscode-microprofile in order to wait for lsp4mp to start when running commands that interact with lsp4mp. Closes redhat-developer#323 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
323-exit-activate-earlier
branch
from
38d88e5 to
2bc47b8
Compare
|
@datho7561 what is the state of this PR? |
|
This strategy doesn't actually address the issue I was trying to solve, which is needing to activate vscode-java in order to use the project generator in vscode-quarkus. This PR means that you can start vscode-microprofile and vscode-quarkus in parallel though, so it cuts down on startup time. I think Fred mentioned that he preferred the other approach that I tried, so I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning from activate when lsp4mp has started, return before it has started. This allows extensions that depend on vscode-microprofile to begin activating before lsp4mp has fully started. Return an API that provides a promise which resolves once lsp4mp has started, so that extensions that need to interact with lsp4mp can wait until it is ready.
Signed-off-by: David Thompson [email protected]