add option to choose full compile/incremental compile #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xuzho <[email protected]>
andxu
reviewed
Nov 10, 2017
src/extension.ts
Outdated
| if (selection === 'Incremental') { | ||
| isFullCompile = false; | ||
| } else { | ||
| isFullCompile = true; |
There was a problem hiding this comment.
isFullCompile = selection === 'Incremental'
andxu
reviewed
Nov 10, 2017
src/extension.ts
Outdated
| const elapsed = new Date().getTime() - start; | ||
| const humanVisibleDelay = elapsed < 1000? 1000:0; | ||
| return new Promise((resolve, reject) => | ||
| { | ||
| setTimeout(function () { // set a timeout so user would still see the message when build time is short |
There was a problem hiding this comment.
function should be replaced with lamda
andxu
reviewed
Nov 10, 2017
src/extension.ts
Outdated
| } | ||
| p.report({ message: 'Compiling workspace...' }); | ||
| const start = new Date().getTime(); | ||
| return languageClient.sendRequest(CompileWorkspaceRequest.type, isFullCompile).then((s: CompileWorkspaceStatus) => { |
Signed-off-by: xuzho <[email protected]>
fbricon
requested changes
Nov 17, 2017
|
@fbricon nice catch! I'll add one more check |
Signed-off-by: xuzho <[email protected]>
ansyral
force-pushed
the
incrementalbuild
branch
from
e318723 to
ddaca46
Compare
fbricon
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xuzho [email protected]