Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import the Janus backend plugins #770

Merged

Conversation

davidfestal
Copy link
Contributor

Description

Import the Janus backend plugins from the backstage-pluginsrepository instead of having wrappers in the showcase repository.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@davidfestal davidfestal requested a review from a team as a code owner November 13, 2023 17:43
Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 130d976

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dynamic-plugins-imports Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

"@janus-idp/backstage-plugin-topology": "1.16.4",
"@janus-idp/backstage-plugin-ocm-backend": "3.4.2",
"@janus-idp/backstage-plugin-keycloak-backend": "1.7.2",
"@janus-idp/backstage-plugin-aap-backend": "1.4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mumbles something about alphabetical sorting of lists

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidfestal davidfestal force-pushed the import-janus-backend-plugins branch from 8c701c5 to 2e0d0b3 Compare November 13, 2023 18:32
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-770!

@davidfestal davidfestal force-pushed the import-janus-backend-plugins branch from 2e0d0b3 to b70bcf0 Compare November 13, 2023 20:58
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-770!

@davidfestal
Copy link
Contributor Author

DO NOT MERGE.

It is still failing for now on OpenShift due to janus-idp/backstage-plugins#932

instead of having wrapers in the showcase repository.

Signed-off-by: David Festal <[email protected]>
@davidfestal davidfestal force-pushed the import-janus-backend-plugins branch from b70bcf0 to 130d976 Compare November 14, 2023 09:48
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-770!

Copy link
Contributor

janus-idp bot commented Nov 14, 2023

backstage-showcase Tests on commit 52a6f80 finished successfully.
View test log

@davidfestal davidfestal merged commit 5b413c0 into redhat-developer:main Nov 14, 2023
@davidfestal davidfestal added the cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch label Nov 14, 2023
nickboldt pushed a commit that referenced this pull request Nov 14, 2023
instead of having wrapers in the showcase repository.

Signed-off-by: David Festal <[email protected]>
@nickboldt nickboldt added the cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch. label Nov 14, 2023
@nickboldt
Copy link
Member

picked to 1.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants