chore: use local files instead of latest from main branch #2269
Conversation
Signed-off-by: Christoph Jerolimov <[email protected]>
|
The image is available at: |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
| - type: url | ||
| target: https://github.com/redhat-developer/rhdh/blob/main/catalog-entities/all.yaml | ||
| - type: file | ||
| target: ../../catalog-info.yaml |
There was a problem hiding this comment.
when this app-config is being parsed, is the CWD in ./packages/app? Just making sure that it's okay to put ../../ in a file that is already on the root repo directory
There was a problem hiding this comment.
Hey, the default is packages/backend, the default Backstage scaffolder contains a comment like this:
https://github.com/christoph-jerolimov/backstage-history/blob/main/app-config.yaml#L80-L95
That was removed here. I think this app-config.yaml is only used in local development. Production installation will not see all these "test entities".
But it's maybe worthful to check that again with someone that is more involved into the build process.
| - type: file | ||
| target: ../../catalog-entities/all.yaml | ||
| rules: | ||
| - allow: [Component, System, Group, Resource, Location, Template, API] |
There was a problem hiding this comment.
If we want to allow all entity types here, we can remove the rules right?
@ciiay good question. The reason is: We can't change the e2e tests this way. When you change an entity and also updates the tests, it still loads the data from the main branch instead of your local copy. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ciiay, logonoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer