-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global-header): added config for default header components #2263
base: main
Are you sure you want to change the base?
feat(global-header): added config for default header components #2263
Conversation
The image is available at: |
/test e2e-tests |
3c47b55
to
bd34619
Compare
The image is available at: |
f54e4ea
to
b6c9481
Compare
The image is available at: |
174e308
to
9439980
Compare
The image is available at: |
The image is available at: |
df4e737
to
d7becf7
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change request
1e35b77
to
0bc2227
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin doesn't define this components yet, so this code couldn't be found.
As discussed in Slack. You must update the plugin to the latest release as well.
I share this here so that others see that this PR is on hold until the plugin is updated. :)
0bc2227
to
0c5aa5f
Compare
The image is available at: |
e10a187
to
5413289
Compare
The image is available at: |
5b09355
to
703c7a7
Compare
The image is available at: |
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
703c7a7
to
14938b7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yi Cai <[email protected]>
The image is available at: |
@ciiay , there is no clear line outline for the search box is this okay ? |
@ciiay Tested on cluster Search , Create , Support , Profile . Screen.Recording.2025-02-11.at.1.32.55.AM.mov |
Hi @its-mitesh-kumar , thanks for the review. This has to be tested with rhdh-plugins PR, not ready for testing on a cluster until the rhdh-plugins PR gets in and the new version is out and available. |
Hi @its-mitesh-kumar , this UI aligns up with the Figma design. |
Description
Updated support to "tech-preview"Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
workspaces/global-header/plugins/global-header/
directory runnpx --yes @janus-idp/cli package export-dynamic-plugin --dynamic-plugins-root <path-to-your-rhdh>/dynamic-plugins-root --dev
app-config.local
file:To test out the Notifications icon button, follow the below steps:
To set up notifications frontend, you can add to app-config.yaml:
To send notifications, you can setup external service https://backstage.io/docs/auth/service-to-service-auth/#static-keys-for-plugin-to-plugin-auth like this:
(Make sure this is auth under backend and not the top level auth key)
Then you can use this to send notifications:
Screen recording(uploaded Feb 7):
rhidp_5252_final.mp4