Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migration): refactor hardcoded repo and images (#2172, #2181) #2173

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented Jan 13, 2025

Description

Refactor repo name and image.

  • Repository: janus-idp/backstage-showcase => redhat-developer/rhdh
  • Quay.io:janus-idp/backstage-showcase => rhdh-community/rhdh

This fixes this error caused by having hardcoded variables and the repo migration:

cp: cannot stat '/tmp/backstage-showcase/e2e-tests/test-results/*': No such file or directory

Should fix also:

Timed out waiting for Docker image redhat-developer/rhdh:pr-2179-3b39bd3a. Time elapsed: 50 minute(s).

Which issue(s) does this PR fix

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@zdrapela
Copy link
Member Author

/retest

@zdrapela zdrapela changed the title chore(ci): refactor hardcoded backstage-showcase in e2e tests chore(ci): refactor hardcoded backstage-showcase in e2e tests (#2172) Jan 13, 2025
Copy link
Collaborator

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@josephca
Copy link
Collaborator

josephca commented Jan 13, 2025

@zdrapela please refer to the comment: #2174 (comment)

Latest images are at https://quay.io/repository/rhdh-community/rhdh?tab=tags&tag=latest instead of in the janus-idp/backstage-showcase quay location. Please update accordingly.

@zdrapela zdrapela changed the title chore(ci): refactor hardcoded backstage-showcase in e2e tests (#2172) chore(migration): refactor hardcoded backstage-showcase in e2e tests (#2172) Jan 14, 2025
@openshift-ci openshift-ci bot removed the lgtm label Jan 14, 2025
Copy link

openshift-ci bot commented Jan 14, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdrapela zdrapela changed the title chore(migration): refactor hardcoded backstage-showcase in e2e tests (#2172) chore(migration): refactor hardcoded repo and images (#2172, #2181) Jan 14, 2025
Copy link
Contributor

@zdrapela
Copy link
Member Author

/test e2e-tests

1 similar comment
@zdrapela
Copy link
Member Author

/test e2e-tests

@zdrapela zdrapela mentioned this pull request Jan 14, 2025
5 tasks
Copy link
Contributor

Copy link
Contributor

@zdrapela
Copy link
Member Author

/retest

1 similar comment
@zdrapela
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Jan 15, 2025

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests d0f7f92 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zdrapela
Copy link
Member Author

Closing in favor of #2192

@zdrapela zdrapela closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants