-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(migration): refactor hardcoded repo and images (#2172, #2181) #2173
chore(migration): refactor hardcoded repo and images (#2172, #2181) #2173
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@zdrapela please refer to the comment: #2174 (comment)
|
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josephca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
/test e2e-tests |
1 similar comment
/test e2e-tests |
The image is available at: |
Co-authored-by: Nick Boldt <[email protected]>
Quality Gate passedIssues Measures |
The image is available at: |
/retest |
1 similar comment
/retest |
@zdrapela: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closing in favor of #2192 |
Description
Refactor repo name and image.
janus-idp/backstage-showcase
=>redhat-developer/rhdh
janus-idp/backstage-showcase
=>rhdh-community/rhdh
This fixes this error caused by having hardcoded variables and the repo migration:
Should fix also:
Which issue(s) does this PR fix
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer