Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump topology plugin to 1.18.8 #1118

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

invincibleJai
Copy link
Contributor

Description

Bump the topology plugin to include the fix for routes sown for workloads with same name, across namespaces

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@invincibleJai invincibleJai requested a review from a team as a code owner March 26, 2024 10:32
@invincibleJai
Copy link
Contributor Author

/cc @karthikjeeyar
/cc @rohitkrai03

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@invincibleJai
Copy link
Contributor Author

/cc @nickboldt

@openshift-ci openshift-ci bot requested a review from nickboldt March 26, 2024 10:33
@invincibleJai
Copy link
Contributor Author

/cherry-pick 1.1.x

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: once the present PR merges, I will cherry-pick it on top of 1.1.x in a new PR and assign it to you.

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1118!

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit 3758a55 into redhat-developer:main Mar 26, 2024
5 of 6 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: new pull request created: #1123

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants