-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump topology plugin to 1.18.8 #1118
chore(deps): bump topology plugin to 1.18.8 #1118
Conversation
/cc @karthikjeeyar |
Quality Gate passedIssues Measures |
/cc @nickboldt |
/cherry-pick 1.1.x |
@invincibleJai: once the present PR merges, I will cherry-pick it on top of 1.1.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@invincibleJai: new pull request created: #1123 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Bump the topology plugin to include the fix for routes sown for workloads with same name, across namespaces
Which issue(s) does this PR fix
Fixes #?
https://issues.redhat.com/browse/RHTAPBUGS-1166
https://issues.redhat.com/browse/RHIDP-1693
fix(topology): adds check on service and routes to match same namespace as workloads janus-idp/backstage-plugins#1389
https://github.com/janus-idp/backstage-plugins/releases/tag/%40janus-idp%2Fbackstage-plugin-topology%401.18.8
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer