-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global-header): initial PR for global header plugin #203
base: main
Are you sure you want to change the base?
feat(global-header): initial PR for global header plugin #203
Conversation
Changed Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a great initial PR. 👍
Some small comments below and I think it's worthful if you can also address here:
- Add a line to .github/CODEOWNERs :)
- Please add a backstage app. I think its in general a good way to test plugins, but it's esp. useful for this plugin.
- Address my comments below and (optional if you really want do that in a follow-up PR, but I think there no reason to rush ;)) split the GlobalHeader file a bit and remove the examples components.
workspaces/global-header/plugins/global-header/src/components/GlobalHeader.tsx
Outdated
Show resolved
Hide resolved
workspaces/global-header/plugins/global-header/src/components/GlobalHeader.tsx
Outdated
Show resolved
Hide resolved
workspaces/global-header/plugins/global-header/src/components/GlobalHeader.tsx
Show resolved
Hide resolved
65fbdaa
to
81e7ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if you can take a look into the comments below.
Here or in a follow up PR is up to you. But since you should also check why the build is failing, it's maybe easier to address them here directly.
Everything else looks nice!
...obal-header/plugins/global-header/src/components/HeaderDropdownComponent/ProfileDropdown.tsx
Show resolved
Hide resolved
@ciiay for the typescript errors in node_modules (duplicate type or something) we changes some of the workspaces to skipLibCheck (that means it doesn't validate node_module TS definitions):
It's somehow related to a Node.js type and and some library type mismatches. It's fine to disable that check here as well. |
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
8e51028
to
bdfe5b3
Compare
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Hey, I just made a Pull Request!
Initial PR for RHIDP-5251
✔️ Checklist
Screen recordings
plugins/global-header test
rhidp_5251.mp4
dev env test
rhidp_5251_dev.mp4