fix(theme): add mui v4 and v5 grid examples #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR adds
Backstage defines a default spacing for all Grids, see:
https://github.com/backstage/backstage/blob/3d2e95f71c2be9a63530697cf01e482e4f50f98d/packages/theme/src/v5/defaultComponentThemes.ts#L67-L71
The RHDH theme doesn't change the padding or default spacing. But in MUI 5 it's required to add additional padding via spacing to the
Grid container
or to the content (in theGrid item
).The UI will looks unaligned when a padding is added to the
Grid item
.MUI v4 and v5 looks similar if no padding is added to the
Grid item
But it's not okay to add padding to
Grid item
in MUI v5:MUI v4
MUI v5
✔️ Checklist