ci: Fix issue that could skip PR container builds if the fork repo is outdated #1060
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: PR Bundle Manifests Validator | |
| on: | |
| # pull_request_target needed to be able to commit and push bundle diffs to external fork PRs. | |
| # But we included a manual authorization safeguard to prevent PWN requests. See the 'authorize' job below. | |
| pull_request_target: | |
| branches: | |
| - main | |
| - rhdh-1.[0-9]+ | |
| - 1.[0-9]+.x | |
| - release-1.[0-9]+ | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.number }} | |
| cancel-in-progress: true | |
| jobs: | |
| authorize: | |
| # The 'external' environment is configured with the maintainers team as required reviewers. | |
| # All the subsequent jobs in this workflow 'need' this job, which will require manual approval for PRs coming from external forks. | |
| # see list of approvers in OWNERS file | |
| environment: | |
| ${{ (github.event.pull_request.head.repo.full_name == github.repository || | |
| contains(fromJSON('["coreydaley","gazarenkov","kadel","nickboldt","rm3l","kim-tsao","openshift-cherrypick-robot"]'), github.actor)) && 'internal' || 'external' }} | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: approved | |
| run: echo "✓" | |
| pr-bundle-diff-checks: | |
| name: PR Bundle Diff | |
| runs-on: ubuntu-latest | |
| needs: authorize | |
| permissions: | |
| contents: write | |
| pull-requests: write | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | |
| with: | |
| fetch-depth: 0 | |
| ref: "${{ github.event.pull_request.merge_commit_sha }}" | |
| - name: Setup Go | |
| uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5 | |
| with: | |
| go-version-file: 'go.mod' | |
| - name: Check for outdated bundle | |
| id: bundle-diff-checker | |
| run: | | |
| for profile in backstage.io rhdh; do make bundle PROFILE=${profile}; done | |
| git status --porcelain | |
| # Since operator-sdk 1.26.0, `make bundle` changes the `createdAt` field from the bundle every time we run it. | |
| # The `git diff` below checks if only the createdAt field has changed. If is the only change, it is ignored. | |
| # Inspired from https://github.com/operator-framework/operator-sdk/issues/6285#issuecomment-1415350333 | |
| echo "MANIFESTS_CHANGED=$(if git diff --quiet -I'^ createdAt: ' bundle; then echo "false"; else echo "true"; fi)" >> $GITHUB_OUTPUT | |
| - name: Commit any manifest changes | |
| if: ${{ steps.bundle-diff-checker.outputs.MANIFESTS_CHANGED == 'true' }} | |
| run: | | |
| git config user.name 'github-actions[bot]' | |
| git config user.email 'github-actions[bot]@users.noreply.github.com' | |
| git fetch --prune | |
| git pull --rebase --autostash | |
| git add -A . | |
| git commit \ | |
| -m "Regenerate bundle manifests" \ | |
| -m "Co-authored-by: $GITHUB_ACTOR <[email protected]>" | |
| git push | |
| - name: Comment on PR if bundle manifests were updated | |
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7 | |
| if: ${{ !cancelled() && steps.bundle-diff-checker.outputs.MANIFESTS_CHANGED == 'true' }} | |
| continue-on-error: true | |
| env: | |
| GH_BLOB_VIEWER_BASE_URL: ${{github.event.pull_request.head.repo.html_url}}/blob/${{github.event.pull_request.head.ref}} | |
| with: | |
| script: | | |
| await github.rest.issues.createComment({ | |
| issue_number: context.issue.number, | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| body: '⚠️ <b>Files changed in bundle generation!</b><br/><br/>Those changes to the operator bundle manifests should have been pushed automatically to your PR branch.<br/>You might also need to manually update the [`.rhdh/bundle/manifests/rhdh-operator.clusterserviceversion.yaml`](${{ env.GH_BLOB_VIEWER_BASE_URL }}/.rhdh/bundle/manifests/rhdh-operator.clusterserviceversion.yaml) CSV file accordingly.' | |
| }) | |
| - name: Check if the CSV for RHDH needs to be updated | |
| run: | | |
| echo "Checking that the RBAC roles of the downstream RHDH operator are not out of sync with the upstream CSV..." | |
| diff -U 1 \ | |
| <(yq '.spec.install.spec.clusterPermissions' bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml | grep -v 'serviceAccountName: ') \ | |
| <(yq '.spec.install.spec.clusterPermissions' .rhdh/bundle/manifests/rhdh-operator.clusterserviceversion.yaml | grep -v 'serviceAccountName: ') |