Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disable dynamic plugin cache PVC by default #79

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fortune-Ndlovu
Copy link

Description of the change

This PR disables the dynamic plugin cache PVC by default in the RHDH Helm Chart.

Changes

  • Introduces dynamicPlugins.cache.ephemeral to control storage behavior.
  • If ephemeral: true (default), the PVC is not created, and emptyDir is used.
  • If ephemeral: false, the PVC is created to persist cached plugins.
  • PVC creation logic is now handled entirely in pvcs.yaml, avoiding if-else in values.yaml.

How to Test

  1. Deploy with ephemeral: true (default) and verify no PVC is created:
    helm upgrade --install rhdh-backstage charts/backstage --namespace rhdh --set dynamicPlugins.cache.ephemeral=true
    oc get pvc -n rhdh  # No dynamic-plugins-root PVC should be present
    
    

Existing or Associated Issue(s)

https://issues.redhat.com/browse/RHIDP-5569

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@openshift-ci openshift-ci bot requested review from coreydaley and tumido January 29, 2025 05:53
@Fortune-Ndlovu Fortune-Ndlovu force-pushed the RHIDP-5569-defaultly-disable-dynamic-plugin-cache-pvc branch from a33ac3f to d37799f Compare January 29, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant