-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon subscription activation and registry service account implementation #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question around all generated classes
if they're automatically generated, should we avoid to store them into the git registry and generate them as part of a npm task ?
@benoitf we can definitely do that, but they not going to change much and also would be good to have generated sources tagged as everything else. Another option is to have npm package per API so other projects, like OpenShift Toolkit, can use it too. |
b99c640
to
5c8916a
Compare
I think that your suggestion with another repository with only the generated classes would be the best option.
|
@vrothberg I would say that there are like 2 ways
assuming you're able to build podman desktop locally you clone https://github.com/containers/podman-desktop/ and https://github.com/redhat-developer/podman-desktop-redhat-account-ext then run yarn inside podman-desktop folder and in podman-desktop-redhat-account-ext then from podman-desktop-folder you do
you fetch a binary of podman desktop you clone this pull request and build the image and publish it somewhere then in Settings/extensions you put the path to the OCI image (need to be a remote one) and then it'll install the extension (this repository has no CI where it's publishing automatically PRs to some OCI registries) |
Thanks a lot, @benoitf ! The instruction were very helpful. |
@vrothberg if you can file an enhancement request at https://github.com/containers/podman-desktop/issues/new?assignees=&labels=kind%2Fenhancement+%E2%9C%A8&projects=&template=enhancement.yml |
Thanks! Opened podman-desktop/podman-desktop#5670 |
One more thing I noticed while playing: The Authentication page displayed "LOGGED OUT" after restarting Podman Desktop. However, we're still logged into the registry and subscription-manager is still working inside the VM (even after reboots). So we need to flesh out what "logged in" and what "logged out" means. |
5503b38
to
b32e61d
Compare
Is this ready to merge? Then we can cut an alpha release and incrementally improve. |
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
56a4fd2
to
f3346df
Compare
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all github workflows, dependency updates, tsconfig changes could be separated small PR as they're not related to the changes
Closed in favor of 0.0.2-alpah.x branch PR #34 |
No description provided.