Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync files on Podman #6348

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 25, 2022

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6335

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit a01907c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63872f8980fd900008ee199b
😎 Deploy Preview https://deploy-preview-6348--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Nov 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from feloy by writing /assign @feloy in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@odo-robot
Copy link

odo-robot bot commented Nov 25, 2022

NoCluster Tests on commit d3dcc04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 25, 2022

Unit Tests on commit d3dcc04 finished successfully.
View logs: TXT HTML

@feloy feloy requested review from rm3l and valaparthvi and removed request for anandrkskd and rnapoles-rh November 25, 2022 17:06
@odo-robot
Copy link

odo-robot bot commented Nov 25, 2022

Validate Tests on commit d3dcc04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 25, 2022

Windows Tests (OCP) on commit d3dcc04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 25, 2022

Kubernetes Tests on commit d3dcc04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 25, 2022

OpenShift Tests on commit d3dcc04 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6335/re-sync-sources-podman branch from 18d3201 to 0d17bc5 Compare November 29, 2022 12:57
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it was just on my machine, but I just noticed a behavior, which I think could be annoying.
When changes are made, they are correctly re-synced, but odo dev keeps detecting changes in the .odo/devstate.json file, and keeps restarting the application.
Do you confirm this behavior on your side?

pkg/dev/podmandev/reconcile.go Outdated Show resolved Hide resolved
@feloy
Copy link
Contributor Author

feloy commented Nov 30, 2022

Not sure if it was just on my machine, but I just noticed a behavior, which I think could be annoying. When changes are made, they are correctly re-synced, but odo dev keeps detecting changes in the .odo/devstate.json file, and keeps restarting the application. Do you confirm this behavior on your side?

Yes you are right, this behaviour happens for every new project where a .gitignore file contains a .odo+ entry, but not a simple .odo entry.

See #6362

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy requested a review from rm3l November 30, 2022 10:36
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 30, 2022
@feloy
Copy link
Contributor Author

feloy commented Nov 30, 2022

/override ci/prow/v4.11-integration-e2e
Infra error
Pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Infra error
Pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f079c3c into redhat-developer:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-sync source files when changed
3 participants