Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remaining Quickstart docs consistent #6324

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Make remaining Quickstart docs consistent #6324

merged 1 commit into from
Nov 23, 2022

Conversation

SD-13
Copy link
Contributor

@SD-13 SD-13 commented Nov 21, 2022 •
edited
Loading

What type of PR is this:
/area documentation
/kind documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes part of #6143

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/documentation labels Nov 21, 2022
@openshift-ci openshift-ci bot requested review from feloy and rm3l November 21, 2022 16:59
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Nov 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

Hi @SD-13. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Nov 21, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 25e2c23
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637dbdea310cd70008b88d6a
😎 Deploy Preview https://deploy-preview-6324--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022 •
edited
Loading

NoCluster Tests on commit cc48ed1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022 •
edited
Loading

Unit Tests on commit cc48ed1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022 •
edited
Loading

Validate Tests on commit cc48ed1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022 •
edited
Loading

Windows Tests (OCP) on commit cc48ed1 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022 •
edited
Loading

Kubernetes Tests on commit cc48ed1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 21, 2022 •
edited
Loading

OpenShift Tests on commit cc48ed1 finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi suggested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, except one comment that I've posted.

docs/website/docs/user-guides/quickstart/dotnet.md Outdated
dotnet new mvc --name app
dotnet new mvc --name <name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep this as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@SD-13 SD-13 force-pushed the consistent_docs_2 branch from 2159adf to 25e2c23 Compare November 23, 2022 06:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SD-13
Copy link
Contributor Author

SD-13 commented Nov 23, 2022

Hi @valaparthvi , I have pushed your suggested change, please take another look when you are free. Thanks,

@valaparthvi
Copy link
Contributor

/lgtm
/approve

Thank you for working on this @SD-13!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 23, 2022
@valaparthvi
Copy link
Contributor

/override windows-integration-test/Windows-test
It's a Docs PR.

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test
It's a Docs PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Nov 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8c24424 into redhat-developer:main Nov 23, 2022
@SD-13 SD-13 deleted the consistent_docs_2 branch November 23, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi requested changes

@feloy feloy Awaiting requested review from feloy

@rm3l rm3l Awaiting requested review from rm3l

Assignees

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SD-13 @valaparthvi @openshift-merge-robot