Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README #6133

Merged

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Sep 19, 2022

What type of PR is this:
/kind documentation
/area documentation

What does this PR do / why we need it:
Small typo in README

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added kind/documentation area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Sep 19, 2022
@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e818256
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/632819f94282cf0008e77696

@openshift-ci openshift-ci bot requested review from cdrage and dharmit September 19, 2022 07:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Sep 19, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 19, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 19, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 19, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 19, 2022

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@dharmit
Copy link
Member

dharmit commented Sep 19, 2022

/override windows-integration-test
/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

@dharmit: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • windows-integration-test

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • netlify/odo-docusaurus-preview/deploy-preview
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override windows-integration-test
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 19, 2022
@dharmit
Copy link
Member

dharmit commented Sep 19, 2022

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

@dharmit: Overrode contexts on behalf of dharmit: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5d4f1b2 into redhat-developer:main Sep 19, 2022
@rm3l rm3l deleted the fix-typo-in-readme branch September 19, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants