Display "Interactive mode enabled" only when running odo init interactively
#6100
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rm3l
requested review from
valaparthvi and
cdrage
and removed request for
rnapoles-rh
|
/lgtm |
openshift-ci
bot
added
the
lgtm
| log.Info("\nInteractive mode enabled, please answer the following questions:") | ||
| if len(o.flags) == 0 { | ||
| log.Infof("\n%s", messages.InteractiveModeEnabled) | ||
| } |
There was a problem hiding this comment.
Can you add a print statement here printing a new line? Currently the message Dowloading devfile ... displayed seems very compact.
There was a problem hiding this comment.
Or do we want to keep the header for the non-interactive command?
There was a problem hiding this comment.
I find the header to provide helpful information about what the command is doing, even in non-interactive mode. It is also displayed in other non-interactive commands like odo deploy. For consistency, I think I'll keep the header for now, and print a new line before "Downloading devfile ...".
There was a problem hiding this comment.
Done - see b48425e91943a6112e904b58eb204d8f2ca7db02.
There was a problem hiding this comment.
I thought you were going to add a header to odo init's non-interactive mode. Were you?
There was a problem hiding this comment.
The header is what we already have in both non-interactive and interactive modes: the logo, the "Initializing new component" and "odo version" messages.
Unless I've misunderstood the comments, I kept this header as it is now, but simply added a new line after it.
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/override ci/prow/v4.10-integration-e2e Tests pass on IBM Cloud |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/v4.10-integration-e2e |
|
@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rm3l
deleted the
5957-running-odo-init-non-interactively-says-interactive-mode-enabled
branch
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5957
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Running
odo initnon-interactively should no longer display the "Interactive mode enabled, please answer the following questions" message.