Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors.go #6059

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Update errors.go #6059

merged 1 commit into from
Aug 29, 2022

Conversation

MahendraBishnoi29
Copy link
Contributor

Fix "Use "odo dev" to deploy it on a cluster" message when odo command is run from an empty directory

What type of PR is this:
/kind bug

What does this PR do / why we need it:
this PR fixes the error message when "odo dev" command runs from a empty dir

Which issue(s) this PR fixes:
this PR fixes #6049

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Please checkout the message changes in errors.go and let me know about it

Fix "Use "odo dev" to deploy it on a cluster" message when odo command is run from an empty directory
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 25, 2022
@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 998c100
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6307798db79ab2000804a5b6

@openshift-ci openshift-ci bot requested review from cdrage and rm3l August 25, 2022 13:31
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Aug 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

Hi @MahendraBishnoi29. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Aug 25, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Aug 25, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Aug 25, 2022
@odo-robot
Copy link

odo-robot bot commented Aug 25, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 25, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 25, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Aug 29, 2022

/lgtm
/approve

Thanks @MahendraBishnoi29 for your help

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3d65090 into redhat-developer:main Aug 29, 2022
@MahendraBishnoi29 MahendraBishnoi29 deleted the patch-1 branch August 29, 2022 07:06
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Fix "Use "odo dev" to deploy it on a cluster" message when odo command is run from an empty directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Use "odo dev" to deploy it on a cluster." message when odo command is run from an empty dir
3 participants