Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send userId to registry when ODO_DEBUG_TELEMETRY_FILE is set #6031

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Do not send userId to registry when ODO_DEBUG_TELEMETRY_FILE is set #6031

merged 2 commits into from
Aug 23, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 18, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5937

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2022
@netlify
Copy link

netlify bot commented Aug 18, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit dff0c76
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62ff98598b1a3b000880ab3e

@openshift-ci openshift-ci bot requested review from cdrage and rm3l August 18, 2022 07:13
@feloy feloy requested review from valaparthvi and removed request for rm3l August 18, 2022 07:14
@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022 •
edited
Loading

Unit Tests on commit 3973248 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022 •
edited
Loading

Validate Tests on commit 3973248 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022 •
edited
Loading

Kubernetes Tests on commit 3973248 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022 •
edited
Loading

OpenShift Tests on commit 3973248 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022 •
edited
Loading

Windows Tests (OCP) on commit 3973248 finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi reviewed Aug 18, 2022
View reviewed changes
pkg/segment/integrations.go Outdated
Comment on lines 30 to 33
if GetDebugTelemetryFile() != "" {
return td, nil
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this faster, perhaps you can put this check on L19, before checking if telemetry is enabled.

@feloy feloy force-pushed the bugfix-5937/disable-telemetry-with-file branch from ef4390d to 45a46a7 Compare August 18, 2022 14:38
@feloy feloy requested a review from valaparthvi August 18, 2022 14:39
valaparthvi
valaparthvi reviewed Aug 19, 2022
View reviewed changes
pkg/segment/integrations.go Outdated
@@ -23,6 +23,10 @@ func getTelemetryForDevfileRegistry() (registryLibrary.TelemetryData, error) {
return td, err
}

if GetDebugTelemetryFile() != "" {
Copy link
Contributor

@valaparthvi valaparthvi Aug 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to suggest you can move this to L19, before initializing the preference client.

@feloy feloy force-pushed the bugfix-5937/disable-telemetry-with-file branch from 45a46a7 to c231803 Compare August 19, 2022 12:59
@feloy feloy requested a review from valaparthvi August 19, 2022 13:00
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 19, 2022
valaparthvi
valaparthvi reviewed Aug 19, 2022
View reviewed changes
pkg/segment/integrations.go
@@ -17,6 +17,10 @@ func getTelemetryForDevfileRegistry() (registryLibrary.TelemetryData, error) {
Client: TelemetryClient,
}

if GetDebugTelemetryFile() != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a unit test for this well which might need enhancing, can you check?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 19, 2022
@feloy feloy requested a review from valaparthvi August 19, 2022 14:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 19, 2022
@feloy feloy requested review from dharmit and removed request for cdrage August 23, 2022 11:47
@dharmit
Copy link
Member

dharmit commented Aug 23, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 23, 2022
@feloy
Copy link
Contributor Author

feloy commented Aug 23, 2022

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit eb3320b into redhat-developer:main Aug 23, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@feloy @cdrage
Do not send userId to registry when ODO_DEBUG_TELEMETRY_FILE is set (r…
e46f343 
…edhat-developer#6031)

* Do not send userId to registry when ODO_DEBUG_TELEMETRY_FILE is set

* Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi approved these changes

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when ODO_DEBUG_TELEMETRY_FILE is set odo should not send telementry via devfile library
4 participants
@feloy @dharmit @valaparthvi @openshift-merge-robot