Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions: ComponentExist, PushedComponent #5944

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Jul 13, 2022

Signed-off-by: Parthvi Vala [email protected]

What type of PR is this:
/kind cleanup

What does this PR do / why we need it:
This PR removes unused functions/methods that I encountered while working on #5923.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 59262ba
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62ced23ed94b950008a08968

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

@valaparthvi: The label(s) area/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

…Cluster to List

Signed-off-by: Parthvi Vala [email protected]

What type of PR is this:
/area cleanup

What does this PR do / why we need it:
This PR removes unused functions/methods that I encountered while working on #5923.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odo-robot
Copy link

odo-robot bot commented Jul 13, 2022

Validate Tests on commit 95a085c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 13, 2022

Unit Tests on commit 95a085c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 13, 2022

Kubernetes Tests on commit 95a085c finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 13, 2022

Windows Tests (OCP) on commit 95a085c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 13, 2022

OpenShift Tests on commit 95a085c finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@feloy
Copy link
Contributor

feloy commented Jul 13, 2022

/lgtm
/approve

/override Kubernetes Integration Tests/Kubernetes Integration Tests

failed to do request: Head "https://registry.stage.devfile.io/v2/devfile-catalog/python/manifests/1.0.0": read tcp 172.30.215.161:46890->3.222.124.43:443: read: connection reset 

/override ci/prow/unit-and-validate-test
Unit and validation tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

@feloy: Overrode contexts on behalf of feloy: Kubernetes Integration Tests/Kubernetes Integration Tests, ci/prow/unit-and-validate-test

In response to this:

/lgtm
/approve

/override Kubernetes Integration Tests/Kubernetes Integration Tests

failed to do request: Head "https://registry.stage.devfile.io/v2/devfile-catalog/python/manifests/1.0.0": read tcp 172.30.215.161:46890->3.222.124.43:443: read: connection reset 

/override ci/prow/unit-and-validate-test
Unit and validation tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 13, 2022
@openshift-ci openshift-ci bot merged commit 62f7c61 into redhat-developer:main Jul 13, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants