Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce test make targets, organize test file structure #5931

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd [email protected]

What type of PR is this:

/area refactoring
/area testing

What does this PR do / why we need it:

This PR removes unnecessary make targets related to tests from Makefile and adds 2 major make targets make test-intigration and make test-e2e, this PR also organize the test files in a single directory.

Which issue(s) this PR fixes:

Fixes #5840

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/refactoring Issues or PRs related to code refactoring label Jul 7, 2022
@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit a4c9f59
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62cdd29d8cad530009bc9c0b
😎 Deploy Preview https://deploy-preview-5931--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jul 7, 2022
@openshift-ci openshift-ci bot requested review from dharmit and rnapoles-rh July 7, 2022 19:05
@odo-robot
Copy link

odo-robot bot commented Jul 7, 2022

Unit Tests on commit 2862ed2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2022

OpenShift Tests on commit 2862ed2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2022

Windows Tests (OCP) on commit 2862ed2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2022

Validate Tests on commit 2862ed2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 7, 2022

Kubernetes Tests on commit 2862ed2 finished successfully.
View logs: TXT HTML

Copy link
Contributor

@rnapoles-rh rnapoles-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 8, 2022
@feloy
Copy link
Contributor

feloy commented Jul 12, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 12, 2022
@feloy
Copy link
Contributor

feloy commented Jul 12, 2022

/override ci/prow/unit-and-validate-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test

In response to this:

/override ci/prow/unit-and-validate-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor

feloy commented Jul 13, 2022

/lgtm

/override ci/prow/unit-and-validate-test
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test, ci/prow/v4.10-integration-e2e

In response to this:

/lgtm

/override ci/prow/unit-and-validate-test
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 13, 2022
@openshift-ci openshift-ci bot merged commit c7f3f3b into redhat-developer:main Jul 13, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
…per#5931)

* reduce test make targets, organize test file structure

Signed-off-by: anandrkskd <[email protected]>

* remove report collection

Signed-off-by: anandrkskd <[email protected]>
@anandrkskd anandrkskd deleted the organize-test branch October 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix integration and e2e test organization structure
3 participants