-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce test make targets, organize test file structure #5931
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/unit-and-validate-test |
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd <[email protected]>
1c2f710
to
a4c9f59
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm /override ci/prow/unit-and-validate-test |
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test, ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…per#5931) * reduce test make targets, organize test file structure Signed-off-by: anandrkskd <[email protected]> * remove report collection Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd [email protected]
What type of PR is this:
/area refactoring
/area testing
What does this PR do / why we need it:
This PR removes unnecessary make targets related to tests from Makefile and adds 2 major make targets
make test-intigration
andmake test-e2e
, this PR also organize the test files in a single directory.Which issue(s) this PR fixes:
Fixes #5840
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: