Install and use a reverse proxy for staging devfile registry #5922
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
the
kind/feature
feloy
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
feloy
force-pushed
the
feature-5920/devfile-proxy-for-tests
branch
8 times, most recently
from
6e5a138 to
4e2beab
Compare
feloy
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
force-pushed
the
feature-5920/devfile-proxy-for-tests
branch
from
2f8d3de to
b34dc75
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| # Need to have a DNS server to resolve the FQDNs provided to proxy_pass | ||
| # Use the DNS resolver provided to the container | ||
| resolver 172.21.0.10; |
There was a problem hiding this comment.
Out of curiosity, where did you retrieve this IP address?
There was a problem hiding this comment.
This is the resolver set for the containers (in /etc/resolv.conf) in the IBM Cloud Kubernetes clusters
There was a problem hiding this comment.
openshift-ci
bot
added
the
lgtm
|
@anandrkskd Can you take a look at this? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/unit-and-validate-test |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/unit-and-validate-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test v4.10-integration-e2e |
|
@feloy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Do we need this when the same tests on IBM Cloud have passed? Also, has the issue with unit and 4.10 integration tests on prow been completely addressed, that is, are they reliable again? |
|
The IBM tests have passed in succession, so I am going to override the prow job for integration tests to move this forward. /override ci/prow/v4.10-integration-e2e |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…developer#5922) * Kubernetes Manifests to deploy nginx reverse proxy for staging devfile registry * Get the external address of the loadBalancer service for devfile proxy * If DEVFILE_PROXY is defined, use it as Devfile registry * Fix get address from Windows * Add some log displaying proxy address found * Filter requests on user agent * Add Go-http-client user-agent * Add doc
What type of PR is this:
/kind feature
Installs a reverse proxy based on nginx to cache the requests to
https://registry.stage.devfile.ioLimits the requests by User-Agent
I didn't find a way to configure the Load Balancer for nginx to see the original IP address of the client andd filter on this IP (the only IP nginx is seeing is the IP address of the load balancer)
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5920
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: