Remove "unmaintained" banner for 2.5.0 #5884
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Why are we removing this banner? I thought it was the way to alert the user they had landed in the "wrong" documentation section. Without this banner, it is not straightforward to distinguish between v2.5 and v3 pages |
**What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Removes the "unmaintained" part of website when it refers to 2.5.0 **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> N/A **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Unfortunately Docusaurus automatically adds a "unmaintained" banner if the version number is lower than the most current one. So instead, I have disabled the banner and enabled the "badge" so that the version will always show (with a label for stable)
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
**What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Removes the "unmaintained" part of website when it refers to 2.5.0 **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> N/A **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]>
What type of PR is this:
/kind documentation
What does this PR do / why we need it:
Removes the "unmaintained" part of website when it refers to 2.5.0
Which issue(s) this PR fixes:
N/A
How to test changes / Special notes to the reviewer:
Signed-off-by: Charlie Drage [email protected]