Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation issue template #5859

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

kadel
Copy link
Member

@kadel kadel commented Jun 22, 2022

/area documentation

documentation should be in /area documentation

kind is meant to be more like kind of an issue (bug, epic, user-story, feature request etc...)
area is to what area the issue/pr is related to
each issue or PR can have only one kind, but multiple areas

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Jun 22, 2022
@openshift-ci openshift-ci bot requested review from dharmit and rm3l June 22, 2022 09:30
@netlify
Copy link

netlify bot commented Jun 22, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit a9ff129
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62b2e139f0b84e0008b4dcf7

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -3,7 +3,8 @@ name: Documentation
about: Report mistakes or request for documentation
---

/kind documentation
/area documentation
/kind bug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, can you also do something about the /kind cleanup? I can create a new area/cleanup label.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if /kind cleanup make sense. that is probably for a longer discussion.
If we decide to do something with cleanup we can do it in a separate PR

Copy link
Contributor

@valaparthvi valaparthvi Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if /kind cleanup make sense. that is probably for a longer discussion. If we decide to do something with cleanup we can do it in a separate PR

Then maybe remove the /kind cleanup from the template because the label we currently have is deprecated, and keeping it in the template does not make sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused :-/
I don't see any /kind cleanup in this template for documentation.

This PR is supposed to clean up a template for documentation issues, nothing else.

If you are talking about a PR template, that is for a separate discussion in another PR.

@odo-robot
Copy link

odo-robot bot commented Jun 22, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 22, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 22, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 22, 2022

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 22, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 15, 2022
@valaparthvi
Copy link
Contributor

/approve

/override ci/prow/unit-and-validate-test
/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/unit-and-validate-test, windows-integration-test/Windows-test

In response to this:

/approve

/override ci/prow/unit-and-validate-test
/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 18, 2022
@openshift-ci openshift-ci bot merged commit 4152c93 into redhat-developer:main Jul 18, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants