Add Golang to the quickstart guide #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dharmit
suggested changes
Jun 3, 2022
docs/website/versioned_docs/version-3.0.0/user-guides/quickstart.md
Outdated
Show resolved
Hide resolved
docs/website/versioned_docs/version-3.0.0/user-guides/quickstart.md
Outdated
Show resolved
Hide resolved
docs/website/versioned_docs/version-3.0.0/user-guides/quickstart.md
Outdated
Show resolved
Hide resolved
valaparthvi
reviewed
Jun 3, 2022
| ``` | ||
|
|
||
|
|
||
| #### 3. Run the `odo deploycommand |
There was a problem hiding this comment.
Suggested change
| #### 3. Run the `odo deploycommand | |
| #### 3. Run the `odo deploy` command |
valaparthvi
reviewed
Jun 3, 2022
| name: {{RESOURCE_NAME}} | ||
| port: | ||
| number: {{CONTAINER_PORT}} | ||
| ``` |
There was a problem hiding this comment.
Do you think it would help to add a section on what the final devfile.yaml would look like?
There was a problem hiding this comment.
Would make the section too long and we add this in the Devfile reference guide instead
valaparthvi
reviewed
Jun 3, 2022
| # Add the following variables code anywhere in devfile.yaml | ||
| # This MUST be a container registry you are able to access | ||
| variables: | ||
| CONTAINER_IMAGE: quay.io/MYUSERNAME/java-springboot-odo-example |
There was a problem hiding this comment.
Can you add a note asking the user to make sure they change this? I made a mistake of not looking at the comment and tried odo deploy.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
valaparthvi
reviewed
Jun 3, 2022
cdrage
force-pushed
the
add-golang
branch
2 times, most recently
from
603c56c to
ec55fd5
Compare
|
/lgtm |
openshift-ci
bot
added
the
lgtm
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Adds a Java Spring Boot example to the quickstart **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Closes redhat-developer#5746 **PR acceptance criteria:** - [X] Documentation **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]>
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Testing out Golang with `odo` was really straight forward and simple, and I thought I may as well add it to the quick start guide! **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> N/A **PR acceptance criteria:** - [X] Documentation **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]>
openshift-ci
bot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
cdrage
added
the
lgtm
|
Re-adding LGTM label. Had to rebase against master due to conflicts. |
|
Kudos, SonarCloud Quality Gate passed!
|
cdrage
added a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
* Adds Java Spring Boot example to quickstart guide <!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Adds a Java Spring Boot example to the quickstart **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Closes redhat-developer#5746 **PR acceptance criteria:** - [X] Documentation **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]> * Add Golang to the quickstart guide <!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Testing out Golang with `odo` was really straight forward and simple, and I thought I may as well add it to the quick start guide! **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> N/A **PR acceptance criteria:** - [X] Documentation **How to test changes / Special notes to the reviewer:** Signed-off-by: Charlie Drage <[email protected]> * update * add odo delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind documentation
What does this PR do / why we need it:
Testing out Golang with
odowas really straight forward and simple,and I thought I may as well add it to the quick start guide!
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:
How to test changes / Special notes to the reviewer:
Signed-off-by: Charlie Drage [email protected]