odo remove binding #5787
Merged
odo remove binding #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
the
kind/feature
valaparthvi
force-pushed
the
remove_binding
branch
from
e04e4cf to
cfdb664
Compare
valaparthvi
force-pushed
the
remove_binding
branch
from
cfdb664 to
3ca8c24
Compare
openshift-ci
bot
added
the
needs-rebase
valaparthvi
force-pushed
the
remove_binding
branch
from
9729486 to
3b5ab3e
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/retest-required |
feloy
reviewed
Jun 7, 2022
| title: odo remove binding | ||
| --- | ||
|
|
||
| The `odo remove binding` command removes the link created between the component and a service via Service Binding. |
There was a problem hiding this comment.
Could you please follow the format of this page, with "Description" and "Running the command" section?
pkg/binding/add_binding.go
Outdated
| @@ -0,0 +1,83 @@ | |||
| package binding | |||
There was a problem hiding this comment.
I think you could name the files add.go and remove.go
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
openshift-ci
bot
added
the
needs-rebase
valaparthvi
force-pushed
the
remove_binding
branch
from
bb449d3 to
242272f
Compare
openshift-ci
bot
removed
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/retest-required |
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
* odo remove binding Signed-off-by: Parthvi Vala <[email protected]> * Documentation Signed-off-by: Parthvi Vala <[email protected]> * Refactor pkg/binding and separate add and remove code * Add unit test * Rebase alterations * Refactor * Philippe's review Signed-off-by: Parthvi Vala <[email protected]> * Rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Parthvi Vala [email protected]
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR adds support for removing binding from the devfile
Which issue(s) this PR fixes:
Fixes #5693
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
mkdir /tmp/105; cd /tmp/105wget https://gist.githubusercontent.com/valaparthvi/dc79e1b3854fff8b55b80b96db9e58c8/raw/4b5d8eb7532f88b18e1ab63fe13c9d3f67a678e3/devfile.yaml3.1
odo remove binding --name cluster-sample-my-node-app3.2
odo remove binding --name cluster-sample-my-node-app-1