Wait for deployment rollout only when binding created / modified #5785
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
feloy
force-pushed
the
bugfix-5781/no-wait-unmodified-binding
branch
from
81fbde4 to
1204a80
Compare
|
@feloy, Tomas mentioned in the call yday that we require integration tests for this, can you add them? |
1 similar comment
|
@feloy, Tomas mentioned in the call yday that we require integration tests for this, can you add them? |
feloy
force-pushed
the
bugfix-5781/no-wait-unmodified-binding
branch
from
1204a80 to
d3463bd
Compare
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
feloy
force-pushed
the
bugfix-5781/no-wait-unmodified-binding
branch
from
d3463bd to
b24a302
Compare
feloy
force-pushed
the
bugfix-5781/no-wait-unmodified-binding
branch
from
b24a302 to
8334e38
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
openshift-ci
bot
added
the
lgtm
|
/override /tide |
|
@feloy: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override tide |
|
@feloy: Overrode contexts on behalf of feloy: tide In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/v4.10-integration-e2e flaky test Tests pass on IBM cloud |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…hat-developer#5785) * Wait for deployment rollout only when binding created / modified * Add integration test
What type of PR is this:
/kind bug
What does this PR do / why we need it:
This PR tests during the patch of the service binding if this one has been created/updated or not, during
odo dev.If the binding has not been created or updated, odo dev does not wait for the pod to restart
Which issue(s) this PR fixes:
Fixes #5781
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: