Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart guide #5763

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented May 24, 2022

What type of PR is this:

/kind documentation

What does this PR do / why we need it:

What's done:

  • Minor update to the quickstart guide to remove references to my username
  • Add more details how to test under Deploy

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Charlie Drage [email protected]

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind documentation

**What does this PR do / why we need it:**

What's done:
- Minor update to the quickstart guide to remove references to my username
- Add more details how to test under Deploy

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

N/A

**PR acceptance criteria:**

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

Signed-off-by: Charlie Drage <[email protected]>
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 87e715a
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/628e1e40613548000ab79d7f
😎 Deploy Preview https://deploy-preview-5763--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented May 24, 2022

Unit Tests on commit f767e35 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2022

Windows Tests (OCP) on commit f767e35 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2022

OpenShift Tests on commit f767e35 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2022

Kubernetes Tests on commit f767e35 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 24, 2022

Validate Tests on commit f767e35 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 25, 2022
@cdrage
Copy link
Member Author

cdrage commented May 25, 2022

Thanks @valaparthvi ! Since it's docs and only needs 1 review, I'll approve this and have it merged.

@cdrage cdrage added approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow. labels May 25, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@openshift-ci
Copy link

openshift-ci bot commented May 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b40607f into redhat-developer:main May 25, 2022
cdrage added a commit to cdrage/odo that referenced this pull request Aug 31, 2022
* Update quickstart guide

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind documentation

**What does this PR do / why we need it:**

What's done:
- Minor update to the quickstart guide to remove references to my username
- Add more details how to test under Deploy

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

N/A

**PR acceptance criteria:**

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

Signed-off-by: Charlie Drage <[email protected]>

* Update docs/website/versioned_docs/version-3.0.0/user-guides/quickstart.md

Co-authored-by: Parthvi Vala <[email protected]>

Co-authored-by: Parthvi Vala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants