Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo registry -o json #5739

Merged
merged 7 commits into from
May 16, 2022
Merged

odo registry -o json #5739

merged 7 commits into from
May 16, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 12, 2022 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

  • ref doc for odo registry
  • odo registry -o json
  • ref doc for odo registry -o json
  • Move structures used for JSON output to api package

Which issue(s) this PR fixes:

Fixes #5644

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 12, 2022
@openshift-ci openshift-ci bot requested review from cdrage and dharmit May 12, 2022 16:57
@feloy feloy changed the title odo registry -o json [wip] odo registry -o json May 12, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 12, 2022
@netlify
Copy link

netlify bot commented May 12, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e8b902c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6282179f70d852000907b068

@odo-robot
Copy link

odo-robot bot commented May 12, 2022 •
edited
Loading

Unit Tests on commit ccf7cfd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 12, 2022 •
edited
Loading

Kubernetes Tests on commit ccf7cfd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 12, 2022 •
edited
Loading

Windows Tests (OCP) on commit ccf7cfd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 12, 2022 •
edited
Loading

OpenShift Tests on commit ccf7cfd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 12, 2022 •
edited
Loading

Validate Tests on commit ccf7cfd finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-5644/odo-registry-json branch from 3a8b342 to 6131ed8 Compare May 13, 2022 07:57
@feloy feloy changed the title [wip] odo registry -o json odo registry -o json May 13, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 13, 2022
@feloy feloy requested review from rm3l and removed request for dharmit May 13, 2022 11:08
rm3l
rm3l requested changes May 13, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. I added few comments however ;)

pkg/api/registry.go Show resolved Hide resolved
docs/website/versioned_docs/version-3.0.0/command-reference/registry.md Show resolved Hide resolved
docs/website/versioned_docs/version-3.0.0/command-reference/json-output.md Outdated Show resolved Hide resolved
rm3l
rm3l reviewed May 13, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small improvement about the error message if a wrong registry is specified.

Wouldn't it be better, from the user perspective, to report that the registry was not found in the registry list, rather than saying no deployable components found?

❯ odo registry --devfile java-maven --devfile-registry fake-registry -o json
{
        "message": "no deployable components found"
}

@feloy feloy requested a review from rm3l May 13, 2022 14:42
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 13, 2022
@rm3l
Copy link
Member

rm3l commented May 16, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 16, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 16, 2022
@feloy
Copy link
Contributor Author

feloy commented May 16, 2022 

• Failure [7.628 seconds]
create/delete/list/get/set namespace tests
/go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:14
  when using the alias namespace to delete a namespace
  /go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:52
    should successfully delete the namespace using the force flag and waiting [It]
    /go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:81

/test v4.10-integration-e2e

@feloy
Copy link
Contributor Author

feloy commented May 16, 2022

Flaky tests on non related tests
Tests pass on IBM Cloud

/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

Flaky tests on non related tests
Tests pass on IBM Cloud

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a26aa6a into redhat-developer:main May 16, 2022
@anandrkskd anandrkskd mentioned this pull request May 17, 2022
Closed
3 tasks
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@feloy @cdrage
odo registry -o json (redhat-developer#5739)
c47233f 
* Doc odo registry

* JSON output

* Move structure for JSON output to api package

* Doc for json output

* Add integration tests

* Review

* Do not rely on devfile version for tests as it is too unstable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@cdrage cdrage Awaiting requested review from cdrage

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an odo registry -o json command
3 participants
@feloy @rm3l @openshift-merge-robot