change path to fix windows log #5692
Conversation
Signed-off-by: anandrkskd <[email protected]>
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Is it #5681 that this PR will fix? |
|
/approve |
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
I guess it worked for me 😸 |
| @@ -20,7 +20,7 @@ echo "RESULT: $RESULT" | |||
| # save log | |||
| source .ibm/pipelines/functions.sh | |||
| ibmcloud login --apikey "${API_KEY}" -r "${IBM_REGION}" | |||
| sshpass -p $WINDOWS_PASSWORD scp -o StrictHostKeyChecking=no Administrator@$WINDOWS_IP:/tmp/${LOGFILE} /tmp/${LOGFILE} | |||
| sshpass -p $WINDOWS_PASSWORD scp -o StrictHostKeyChecking=no Administrator@$WINDOWS_IP:~/AppData/Local/Temp/${LOGFILE} /tmp/${LOGFILE} | |||
There was a problem hiding this comment.
Could you use the TEMP environment variable value instead?
There was a problem hiding this comment.
Also, I can see the use of /tmp in other places in the script, can you update them also?
There was a problem hiding this comment.
My bad, this script is running on the Linux side, right?
Signed-off-by: anandrkskd <[email protected]>
Signed-off-by: anandrkskd [email protected]
What type of PR is this:
/kind tests
What does this PR do / why we need it:
This PR will fix the broken link to the logs for the windows CI tests.
Which issue(s) this PR fixes:
Fixes #5680
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: