Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documenation for env variables used by odo #5686

Merged
merged 2 commits into from
Aug 2, 2022
Merged

add documenation for env variables used by odo #5686

merged 2 commits into from
Aug 2, 2022

Conversation

kadel
Copy link
Member

@kadel kadel commented Apr 22, 2022

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 22, 2022
@netlify
Copy link

netlify bot commented Apr 22, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 185c345
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62e8ed22335c7a000a767669
😎 Deploy Preview https://deploy-preview-5686--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from feloy and valaparthvi April 22, 2022 12:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Apr 22, 2022 •
edited
Loading

Unit Tests on commit 43d5157 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 22, 2022 •
edited
Loading

Windows Tests (OCP) on commit 43d5157 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 22, 2022 •
edited
Loading

Kubernetes Tests on commit 43d5157 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 22, 2022 •
edited
Loading

OpenShift Tests on commit 43d5157 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 22, 2022 •
edited
Loading

Validate Tests on commit 43d5157 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2022

@kadel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-and-validate-test 44d3193 link true /test unit-and-validate-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kadel kadel force-pushed the docs-env-variables branch from 44d3193 to a48da01 Compare July 14, 2022 11:24
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 14, 2022
@kadel kadel force-pushed the docs-env-variables branch from a48da01 to bb74fc0 Compare July 15, 2022 10:34
@kadel kadel changed the title [WIP] add documenation for env variables used by odo add documenation for env variables used by odo Aug 1, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 1, 2022
@kadel kadel mentioned this pull request Aug 1, 2022
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 2, 2022
@feloy
Copy link
Contributor

feloy commented Aug 2, 2022

/override windows-integration-test/Windows-test

X  unable to download devfile: Get "[https://registry.stage.devfile.io/index":](https://registry.stage.devfile.io/index%22:) read tcp 10.243.64.4:55422->54.209.128.46:443: wsarecv: An existing connection was forcibly closed by the remote host.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

X  unable to download devfile: Get "[https://registry.stage.devfile.io/index":](https://registry.stage.devfile.io/index%22:) read tcp 10.243.64.4:55422->54.209.128.46:443: wsarecv: An existing connection was forcibly closed by the remote host.

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4c266a6 into redhat-developer:main Aug 2, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@kadel @feloy @cdrage
add documenation for env variables used by odo (redhat-developer#5686)
5f0027c 
* add documenation for env variables used by odo

* Update docs/website/docs/overview/configure.md

Co-authored-by: Philippe Martin <[email protected]>

Co-authored-by: Philippe Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kadel @feloy @openshift-merge-robot