odo init json output
#5658
Merged
odo init json output
#5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
the
kind/feature
feloy
requested review from
rm3l and
valaparthvi
and removed request for
kadel and
anandrkskd
feloy
force-pushed
the
odo-init-json-main
branch
from
482b02d to
716a3f3
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
valaparthvi
suggested changes
Apr 14, 2022
pkg/odo/cli/init/init.go
Outdated
Comment on lines
130
to
137
| commands, _ := devfileObj.Data.GetCommands(common.DevfileOptions{ | ||
| CommandOptions: common.CommandOptions{ | ||
| CommandGroupKind: v1alpha2.DeployCommandGroupKind, | ||
| }, | ||
| }) | ||
| if len(commands) != 0 { | ||
| exitMessage += "\nTo deploy your component to a cluster use \"odo deploy\"." | ||
| } |
There was a problem hiding this comment.
Can you replace this with libdevfile.HasDeployCommand() method?
Suggested change
| commands, _ := devfileObj.Data.GetCommands(common.DevfileOptions{ | |
| CommandOptions: common.CommandOptions{ | |
| CommandGroupKind: v1alpha2.DeployCommandGroupKind, | |
| }, | |
| }) | |
| if len(commands) != 0 { | |
| exitMessage += "\nTo deploy your component to a cluster use \"odo deploy\"." | |
| } | |
| if libdevfile.HasDeployCommand(devfileObj.Data) { | |
| exitMessage += "\nTo deploy your component to a cluster use \"odo deploy\"." | |
| } |
feloy
force-pushed
the
odo-init-json-main
branch
from
dc034e1 to
847138c
Compare
valaparthvi
reviewed
Apr 14, 2022
Comment on lines
+149
to
+151
| ForwardedPorts: []api.ForwardedPort{}, | ||
| RunningIn: []api.RunningMode{}, | ||
| ManagedBy: "odo", |
There was a problem hiding this comment.
Can you also add these fields in the JSON output in the docs?
rm3l
reviewed
Apr 14, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
approved these changes
Apr 15, 2022
openshift-ci
bot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
* odo init -o json * docs * fix header and json * Make DevfileLocation part of api package * Add Component api kind * odo init -o json return value * Document api package * Update tests * review * Error when json output and no flags * Update doc * review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
pkg/apipackageWhich issue(s) this PR fixes:
Fixes #5645
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: