Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix odo interactive with verbosity flags #5601

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix odo interactive with verbosity flags #5601

merged 1 commit into from
Mar 29, 2022

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5513

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
odo init

  1. mkdir /tmp/101; cd /tmp/101
  2. odo init -v 4

odo dev

  1. mkdir /tmp/102; cd /tmp/102
  2. cp -r $ODOPATH/tests/examples/source/nodejs/* .
  3. odo dev -v 4

Ensure both the commands run. Test with odo deploy as well.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 271fa01
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6243162c5f02300009724e46

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 29, 2022
@odo-robot
Copy link

odo-robot bot commented Mar 29, 2022 •
edited
Loading

OpenShift Tests on commit e6750c5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 29, 2022 •
edited
Loading

Unit Tests on commit e6750c5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 29, 2022 •
edited
Loading

Kubernetes Tests on commit e6750c5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 29, 2022 •
edited
Loading

Validate Tests on commit e6750c5 finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@valaparthvi valaparthvi requested a review from rm3l March 29, 2022 14:49
@valaparthvi valaparthvi changed the title [WIP] Fix odo interactive with verbosity flags Fix odo interactive with verbosity flags Mar 29, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 29, 2022
@feloy
Copy link
Contributor

feloy commented Mar 29, 2022

/approve

Tests pass on IBM Cloud
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/approve

Tests pass on IBM Cloud
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit 267bb6a into redhat-developer:main Mar 29, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@valaparthvi @cdrage
Fix odo interactive with verbosity flags (redhat-developer#5601)
4561012 
Signed-off-by: Parthvi Vala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@rm3l rm3l

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run odo init interactively with custom verbosity level flag
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot