Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganized test file directory structure #5537

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Reorganized test file directory structure #5537

merged 2 commits into from
Mar 16, 2022

Conversation

rnapoles-rh
Copy link
Contributor

/kind tests
What does this PR do / why we need it:
We want to reorganize test directory structure

Which issue(s) this PR fixes:
Fixes #5482

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Mar 10, 2022 •
edited
Loading

✔️ Deploy Preview for odo-docusaurus-preview canceled.

🔨 Explore the source changes: 8c21db1

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6230aec4ee728b0008026e63

@openshift-ci openshift-ci bot requested review from feloy and mohammedzee1000 March 10, 2022 16:04
@odo-robot
Copy link

odo-robot bot commented Mar 10, 2022 •
edited
Loading

Unit Tests on commit 619ebbb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 10, 2022 •
edited
Loading

Kubernetes Tests on commit 619ebbb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 10, 2022 •
edited
Loading

OpenShift Tests on commit 619ebbb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 10, 2022 •
edited
Loading

Validate Tests on commit 619ebbb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Mar 10, 2022 •
edited
Loading

Windows Tests (OCP) on commit 619ebbb finished with errors.
View logs: TXT HTML

@rnapoles-rh
Copy link
Contributor Author

infra error
/test v4.9-integration-e2e

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 11, 2022
@feloy feloy removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 11, 2022
@feloy
Copy link
Contributor

feloy commented Mar 11, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 11, 2022
@rnapoles-rh rnapoles-rh force-pushed the 5482-tests-file-dir branch from 6f816a9 to 0d43554 Compare March 11, 2022 14:57
@rnapoles-rh
Copy link
Contributor Author

/test v4.9-integration-e2e

@valaparthvi
Copy link
Contributor

/retest

@cdrage
Copy link
Member

cdrage commented Mar 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 14, 2022
@anandrkskd
Copy link
Contributor

@rnapoles-rh the prow tests are failing due to this, you need to update the script used in prow tests to make them pass, i.e. openshiftci-presubmit-all-tests.sh, openshiftci-periodic-tests.sh

@rnapoles-rh rnapoles-rh force-pushed the 5482-tests-file-dir branch from 0d43554 to 8c21db1 Compare March 15, 2022 15:20
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 15, 2022
@rnapoles-rh
Copy link
Contributor Author

@rnapoles-rh the prow tests are failing due to this, you need to update the script used in prow tests to make them pass, i.e. openshiftci-presubmit-all-tests.sh, openshiftci-periodic-tests.sh

Thank you Anand. Pushing changes to these two scripts

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@valaparthvi
Copy link
Contributor

/lgtm

Tests are passing.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit 83f26da into redhat-developer:main Mar 16, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@rnapoles-rh @cdrage
Reorganized test file directory structure (redhat-developer#5537)
2878938 
* Rebased was required

* Replicated changes to  openshiftci related scripts to avoid test failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@cdrage cdrage cdrage approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@cdrage cdrage

@feloy feloy

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve file structure of /tests directory
6 participants
@rnapoles-rh @feloy @valaparthvi @cdrage @anandrkskd @openshift-merge-robot