Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the Changelog.md with the mention of PR https://github.com/openshift/odo/pull/4588 #4740

Merged

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented May 24, 2021

What type of PR is this?

/kind documentation
[skip ci]

What does this PR do / why we need it:

Which issue(s) this PR fixes:

It updates the Changelog.md with the mention of PR #4588.

Fixes NA

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

  • Verify the change log file.

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 24, 2021
@valaparthvi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 24, 2021
@girishramnani
Copy link
Contributor

/override ci/prow/psi-kubernetes-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2021

@girishramnani: Overrode contexts on behalf of girishramnani: ci/prow/psi-kubernetes-integration-e2e

In response to this:

/override ci/prow/psi-kubernetes-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 75301a4 into redhat-developer:main May 24, 2021
@mik-dass mik-dass deleted the update-changelog branch June 29, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants