Adds a document regarding the odo.dev.push.path attributes in the devfile #4681
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mik-dass The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
mik-dass
added
the
do-not-merge/hold
mik-dass
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mik-dass The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@feloy Fixed |
| commands: | ||
| - id: dev-run | ||
| attributes: | ||
| "dev.odo.push.path:target/quarkus-app": "remote-target/quarkus-app" |
There was a problem hiding this comment.
You mean wherever is being pushed, name of the remote folder will be remote-target. I am getting confused because the remote target mentioned https://github.com/openshift/odo/pull/4681/files#diff-690405b0010238bcf5d1edadd2272c958de0ff87da1d35d75ce9ad3f2fca50a0R29 is target/quarkus-app
Could you please sync both the places 🙂
|
/lgtm |
|
/hold Feel free to unhold when ready to merge |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
lgtm
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
What type of PR is this?
/kind documentation
[skip ci]
What does this PR do / why we need it:
It adds a document regarding the
odo.dev.push.pathrelated attributes for #4588Which issue(s) this PR fixes:
Fixes part of #3132
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: