check if namespace is created instead of project

Signed-off-by: anandrkskd <[email protected]>
redhat-developer · Sep 13, 2022 · f9fc5ab · f9fc5ab
1 parent 77750ec
commit f9fc5ab
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/tests/helper/helper_cli.go b/tests/helper/helper_cli.go
@@ -26,6 +26,7 @@ type CliRunner interface {
 
 	// HasNamespaceProject returns whether the specified namespace or project exists in the cluster
 	HasNamespaceProject(name string) bool
+	HasNamespace(name string)
 
 	GetActiveNamespace() string
 	GetEnvsDevFileDeployment(componentName, appName, projectName string) map[string]string

diff --git a/tests/helper/helper_kubectl.go b/tests/helper/helper_kubectl.go
@@ -389,6 +389,11 @@ func (kubectl KubectlRunner) HasNamespaceProject(name string) bool {
 		ShouldRun().Out()
 	return strings.Contains(out, name)
 }
+func (kubectl KubectlRunner) HasNamespace(name string) {
+	Eventually(func() string {
+		return Cmd(kubectl.path, "get", "ns", name, "-o", "jsonpath={.metadata.name}").ShouldRun().Out()
+	}, 30*time.Second, 1*time.Second).Should(Equal(name))
+}
 
 func (kubectl KubectlRunner) GetActiveNamespace() string {
 	return Cmd(kubectl.path, "config", "view", "--minify", "-ojsonpath={..namespace}").ShouldPass().Out()

diff --git a/tests/helper/helper_oc.go b/tests/helper/helper_oc.go
@@ -582,6 +582,12 @@ func (oc OcRunner) HasNamespaceProject(name string) bool {
 	return strings.Contains(out, name)
 }
 
+func (oc OcRunner) HasNamespace(name string) {
+	Eventually(func() string {
+		return Cmd(oc.path, "get", "ns", name, "-o", "jsonpath={.metadata.name}").ShouldRun().Out()
+	}, 30*time.Second, 1*time.Second).Should(Equal(name))
+}
+
 func (oc OcRunner) GetActiveNamespace() string {
 	return Cmd(oc.path, "config", "view", "--minify", "-ojsonpath={..namespace}").ShouldPass().Out()
 }

diff --git a/tests/integration/interactive_add_binding_test.go b/tests/integration/interactive_add_binding_test.go
@@ -226,8 +226,8 @@ var _ = Describe("odo add binding interactive command tests", func() {
 					helper.GetExamplePath("manifests", "bindablekind-instance.yaml"))
 				Expect(addBindableKindInOtherNs.ExitCode()).To(BeEquivalentTo(0))
 				nsWithNoService = commonVar.CliRunner.CreateAndSetRandNamespaceProject()
-				Expect(commonVar.CliRunner.HasNamespaceProject(nsWithNoService)).Should(Equal(true))
-				Expect(commonVar.CliRunner.HasNamespaceProject(otherNS)).Should(Equal(true))
+				commonVar.CliRunner.HasNamespace(nsWithNoService)
+				commonVar.CliRunner.HasNamespace(otherNS)
 
 				commonVar.CliRunner.SetProject(commonVar.Project)
 			})
@@ -558,8 +558,8 @@ var _ = Describe("odo add binding interactive command tests", func() {
 					helper.GetExamplePath("manifests", "bindablekind-instance.yaml"))
 				Expect(addBindableKindInOtherNs.ExitCode()).To(BeEquivalentTo(0))
 				nsWithNoService = commonVar.CliRunner.CreateAndSetRandNamespaceProject()
-				Expect(commonVar.CliRunner.HasNamespaceProject(nsWithNoService)).Should(Equal(true))
-				Expect(commonVar.CliRunner.HasNamespaceProject(otherNS)).Should(Equal(true))
+				commonVar.CliRunner.HasNamespace(nsWithNoService)
+				commonVar.CliRunner.HasNamespace(otherNS)
 
 				commonVar.CliRunner.SetProject(commonVar.Project)
 			})