Apply suggestions from code review

Co-authored-by: Parthvi Vala <[email protected]>
redhat-developer · Nov 23, 2022 · bfd25e2 · bfd25e2
1 parent 2c0af4d
commit bfd25e2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/dev/podmandev/pod.go b/pkg/dev/podmandev/pod.go
@@ -44,15 +44,15 @@ func createPodFromComponent(
 			Name: storage.OdoSourceVolume,
 			VolumeSource: corev1.VolumeSource{
 				PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{
-					ClaimName: getVolumeName(componentName, appName, "odo-projects"),
+					ClaimName: getVolumeName(storage.OdoSourceVolume, componentName, appName),
 				},
 			},
 		},
 		{
 			Name: storage.SharedDataVolumeName,
 			VolumeSource: corev1.VolumeSource{
 				PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{
-					ClaimName: getVolumeName(componentName, appName, "odo-shared"),
+					ClaimName: getVolumeName(storage.SharedDataVolumeName, componentName, appName),
 				},
 			},
 		},
@@ -68,7 +68,7 @@ func createPodFromComponent(
 			Name: devfileVolume.Name,
 			VolumeSource: corev1.VolumeSource{
 				PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{
-					ClaimName: getVolumeName(componentName, appName, devfileVolume.Name),
+					ClaimName: getVolumeName(devfileVolume.Name, componentName, appName),
 				},
 			},
 		})
@@ -96,7 +96,7 @@ func createPodFromComponent(
 	return &pod, fwPorts, nil
 }
 
-func getVolumeName(componentName string, appName string, volume string) string {
+func getVolumeName(volume string, componentName string, appName string) string {
 	return volume + "-" + componentName + "-" + appName
 }
 

diff --git a/pkg/dev/podmandev/pod_test.go b/pkg/dev/podmandev/pod_test.go
@@ -92,7 +92,7 @@ var (
 					Name: "odo-shared-data",
 					VolumeSource: corev1.VolumeSource{
 						PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{
-							ClaimName: "odo-shared-mycmp-app",
+							ClaimName: "odo-shared-data-mycmp-app",
 						},
 					},
 				},