review

redhat-developer · Jun 13, 2022 · 7201405 · 7201405
1 parent 73947ff
commit 7201405
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/pkg/vars/vars.go b/pkg/vars/vars.go
@@ -92,6 +92,12 @@ func parseKeyValueString(s string, lookupEnv func(string) (string, bool)) (strin
 	parts := strings.SplitN(line, "=", 2)
 	key := parts[0]
 
+	// TODO validate key format
+
+	if len(key) == 0 {
+		return "", "", NewErrBadKey(fmt.Sprintf("no key defined in line %q", s))
+	}
+
 	var value string
 	if len(parts) > 1 {
 		value = parts[1]
@@ -103,10 +109,5 @@ func parseKeyValueString(s string, lookupEnv func(string) (string, bool)) (strin
 		}
 	}
 
-	// TODO validate key format
-
-	if len(key) == 0 {
-		return "", "", NewErrBadKey(fmt.Sprintf("no key defined in line %q", s))
-	}
 	return key, value, nil
 }