Arm3l review

docs/website/versioned_docs/version-3.0.0/command-reference/create-namespace.md

@@ -5,6 +5,8 @@ sidebar_position: 3
 
 `odo create namespace` lets you create a namespace/project on your cluster. If you are on a Kubernetes cluster, running the command will create a Namespace resource for you, and for an OpenShift cluster, it will create a Project resource.
 
+Any new namespace created with this command will also be set as the current active namespace, this applies to project as well.
+
 To create a namespace you can run `odo create namespace <name>`:
 ```shell
 odo create namespace mynamespace

pkg/odo/cli/create/namespace/namespace.go

@@ -7,6 +7,7 @@ import (
 
 	"context"
 
+	dfutil "github.com/devfile/library/pkg/util"
 	"github.com/spf13/cobra"
 	ktemplates "k8s.io/kubectl/pkg/util/templates"
 
@@ -74,7 +75,7 @@ func (nco *NamespaceCreateOptions) Complete(cmdline cmdline.Cmdline, args []stri
 
 // Validate validates the parameters of the NamespaceCreateOptions
 func (nco *NamespaceCreateOptions) Validate() error {
-	return nil
+	return dfutil.ValidateK8sResourceName("namespace name", nco.namespaceName)
 }
 
 // Run runs the namespace create command

tests/helper/helper_cli.go

@@ -20,6 +20,7 @@ type CliRunner interface {
 	DeletePod(podName string, projectName string)
 	GetNamespaceProject() string
 	CheckNamespaceProjectExists(name string) bool
+	GetActiveNamespace() string
 	GetEnvsDevFileDeployment(componentName, appName, projectName string) map[string]string
 	GetEnvRefNames(componentName, appName, projectName string) []string
 	GetPVCSize(compName, storageName, namespace string) string

tests/helper/helper_kubectl.go

@@ -386,3 +386,7 @@ func (kubectl KubectlRunner) GetNamespaceProject() string {
 func (kubectl KubectlRunner) CheckNamespaceProjectExists(name string) bool {
 	return Cmd(kubectl.path, "get", "namespace", name).ShouldPass().pass
 }
+
+func (kubectl KubectlRunner) GetActiveNamespace() string {
+	return Cmd(kubectl.path, "config", "view", "--minify", "-ojsonpath={..namespace}").ShouldPass().Out()
+}

tests/helper/helper_oc.go

@@ -578,3 +578,7 @@ func (oc OcRunner) GetNamespaceProject() string {
 func (oc OcRunner) CheckNamespaceProjectExists(name string) bool {
 	return Cmd(oc.path, "get", "project", name).ShouldPass().pass
 }
+
+func (oc OcRunner) GetActiveNamespace() string {
+	return Cmd(oc.path, "config", "view", "--minify", "-ojsonpath={..namespace}").ShouldPass().Out()
+}

tests/integration/cmd_namespace_test.go

@@ -30,12 +30,18 @@ var _ = Describe("create/delete/list/get/set namespace tests", func() {
 			})
 			It(fmt.Sprintf("should successfully create the %s", command), func() {
 				Expect(commonVar.CliRunner.CheckNamespaceProjectExists(namespace)).To(BeTrue())
+				Expect(commonVar.CliRunner.GetActiveNamespace()).To(Equal(namespace))
 			})
 		})
 
 	}
 
-	It("should fail to create an existent namespace", func() {
-		helper.Cmd("odo", "create", "namespace", commonVar.Project).ShouldFail()
+	It("should fail to create namespace", func() {
+		By("using an existent namespace name", func() {
+			helper.Cmd("odo", "create", "namespace", commonVar.Project).ShouldFail()
+		})
+		By("using an invalid namespace name", func() {
+			helper.Cmd("odo", "create", "namespace", "12345").ShouldFail()
+		})
 	})
 })