fix: Fix #157

Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
redhat-developer · Nov 22, 2023 · b32ada4 · b32ada4
1 parent 4c57241
commit b32ada4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/pkg/provider/aws/action/fedora/fedora.go b/pkg/provider/aws/action/fedora/fedora.go
@@ -16,6 +16,7 @@ import (
 	amiSVC "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/ami"
 	"github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/keypair"
 	securityGroup "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/security-group"
+	"github.com/adrianriobo/qenvs/pkg/provider/util/command"
 	"github.com/adrianriobo/qenvs/pkg/provider/util/output"
 	"github.com/adrianriobo/qenvs/pkg/util"
 	resourcesUtil "github.com/adrianriobo/qenvs/pkg/util/resources"
@@ -191,7 +192,7 @@ func (r *Request) deploy(ctx *pulumi.Context) error {
 		pulumi.String(amiUserDefault))
 	ctx.Export(fmt.Sprintf("%s-%s", r.Prefix, outputHost),
 		c.GetHostIP(!r.Airgap))
-	return c.Readiness(ctx, r.Prefix, awsFedoraDedicatedID,
+	return c.Readiness(ctx, command.CommandPing, r.Prefix, awsFedoraDedicatedID,
 		keyResources.PrivateKey, amiUserDefault, bastion, []pulumi.Resource{})
 }
 

diff --git a/pkg/provider/aws/action/rhel/rhel.go b/pkg/provider/aws/action/rhel/rhel.go
@@ -18,6 +18,7 @@ import (
 	amiSVC "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/ami"
 	"github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/keypair"
 	securityGroup "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/security-group"
+	"github.com/adrianriobo/qenvs/pkg/provider/util/command"
 	"github.com/adrianriobo/qenvs/pkg/provider/util/output"
 	"github.com/adrianriobo/qenvs/pkg/util"
 	"github.com/adrianriobo/qenvs/pkg/util/file"
@@ -217,7 +218,7 @@ func (r *Request) deploy(ctx *pulumi.Context) error {
 		pulumi.String(amiUserDefault))
 	ctx.Export(fmt.Sprintf("%s-%s", r.Prefix, outputHost),
 		c.GetHostIP(!r.Airgap))
-	return c.Readiness(ctx, r.Prefix, awsRHELDedicatedID,
+	return c.Readiness(ctx, command.CommandCloudInitWait, r.Prefix, awsRHELDedicatedID,
 		keyResources.PrivateKey, amiUserDefault, bastion, []pulumi.Resource{})
 }
 

diff --git a/pkg/provider/aws/action/windows/windows.go b/pkg/provider/aws/action/windows/windows.go
@@ -19,6 +19,7 @@ import (
 	amiSVC "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/ami"
 	"github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/keypair"
 	securityGroup "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/security-group"
+	"github.com/adrianriobo/qenvs/pkg/provider/util/command"
 	"github.com/adrianriobo/qenvs/pkg/provider/util/output"
 	"github.com/adrianriobo/qenvs/pkg/provider/util/security"
 	"github.com/adrianriobo/qenvs/pkg/util"
@@ -253,7 +254,7 @@ func (r *Request) deploy(ctx *pulumi.Context) error {
 		password.Result)
 	ctx.Export(fmt.Sprintf("%s-%s", r.Prefix, outputHost),
 		c.GetHostIP(!r.Airgap))
-	return c.Readiness(ctx, r.Prefix, awsWindowsDedicatedID,
+	return c.Readiness(ctx, command.CommandPing, r.Prefix, awsWindowsDedicatedID,
 		keyResources.PrivateKey, r.AMIUser, bastion, []pulumi.Resource{})
 }
 

diff --git a/pkg/provider/aws/modules/ec2/compute/compute.go b/pkg/provider/aws/modules/ec2/compute/compute.go
@@ -197,8 +197,9 @@ func (c *Compute) GetHostIP(public bool) (ip pulumi.StringInput) {
 	return c.LB.DnsName
 }
 
-// Check if compute is healthy (ping on ssh)
+// Check if compute is healthy based on running a remote cmd
 func (compute *Compute) Readiness(ctx *pulumi.Context,
+	cmd string,
 	prefix, id string,
 	mk *tls.PrivateKey, username string,
 	b *bastion.Bastion,
@@ -207,8 +208,8 @@ func (compute *Compute) Readiness(ctx *pulumi.Context,
 		resourcesUtil.GetResourceName(prefix, id, "readiness-cmd"),
 		&remote.CommandArgs{
 			Connection: remoteCommandArgs(compute, mk, username, b),
-			Create:     pulumi.String(command.CommandPing),
-			Update:     pulumi.String(command.CommandPing),
+			Create:     pulumi.String(cmd),
+			Update:     pulumi.String(cmd),
 		}, pulumi.Timeouts(
 			&pulumi.CustomTimeouts{
 				Create: command.RemoteTimeout,