Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent from NPE CancellationSupport #576

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: prevent from NPE CancellationSupport #576

merged 1 commit into from
Oct 14, 2024

Conversation

angelozerr
Copy link
Contributor

fix: prevent from NPE CancellationSupport

I cannot reproduce his issue, but @ia3andy reported me that he had this error sometimes:

java.lang.IllegalArgumentException: Argument for @NotNull parameter 'cancellationSupport' of com/redhat/devtools/lsp4ij/features/codeAction/intention/LSPIntentionCodeActionSupport.doLoad must not be null
	at com.redhat.devtools.lsp4ij.features.codeAction.intention.LSPIntentionCodeActionSupport.$$$reportNull$$$0(LSPIntentionCodeActionSupport.java)
	at com.redhat.devtools.lsp4ij.features.codeAction.intention.LSPIntentionCodeActionSupport.doLoad(LSPIntentionCodeActionSupport.java)
	at com.redhat.devtools.lsp4ij.features.codeAction.intention.LSPIntentionCodeActionSupport.doLoad(LSPIntentionCodeActionSupport.java:43)
	at com.redhat.devtools.lsp4ij.features.AbstractLSPFeatureSupport.load(AbstractLSPFeatureSupport.java:88)
	at com.redhat.devtools.lsp4ij.features.AbstractLSPDocumentFeatureSupport.load(AbstractLSPDocumentFeatureSupport.java:65)
	at com.redhat.devtools.lsp4ij.features.AbstractLSPFeatureSupport.getFeatureData(AbstractLSPFeatureSupport.java:49)

and it should fix too #486

@angelozerr angelozerr added the bug Something isn't working label Oct 14, 2024
@angelozerr angelozerr added this to the 0.7.0 milestone Oct 14, 2024
@angelozerr angelozerr merged commit 178db4d into redhat-developer:main Oct 14, 2024
5 of 6 checks passed
@angelozerr angelozerr self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@angelozerr