Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: macro support in the start ls command #340

Merged

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Jun 11, 2024

feat: macro support in the start ls command

Fixes #336

Here a sample with scala LS where metal.bat is in the root of project path.

The start command LS uses maco (see available values at https://www.jetbrains.com/help/idea/built-in-macros.html):

$PROJECT_DIR$/metals.bat

image

Label command (on the topof the command) show the preview of the macro

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 23.61%. Comparing base (33a32b4) to head (9a97dff).

Current head 9a97dff differs from pull request most recent head fc8f1a3

Please upload reports for the commit fc8f1a3 to get more accurate results.

Files Patch % Lines
...vtools/lsp4ij/settings/ui/LanguageServerPanel.java 0.00% 25 Missing ⚠️
...launching/UserDefinedLanguageServerDefinition.java 0.00% 3 Missing ⚠️
...s/lsp4ij/launching/ui/NewLanguageServerDialog.java 0.00% 1 Missing ⚠️
...t/devtools/lsp4ij/settings/LanguageServerView.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   23.74%   23.61%   -0.14%     
==========================================
  Files         265      265              
  Lines        9078     9103      +25     
  Branches     1241     1658     +417     
==========================================
- Hits         2156     2150       -6     
- Misses       6515     6547      +32     
+ Partials      407      406       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angelozerr angelozerr force-pushed the macro_start_command_user_defined_ls branch 3 times, most recently from eea4daa to ec0ff98 Compare June 11, 2024 12:25
@angelozerr angelozerr marked this pull request as ready for review June 11, 2024 12:26
@fbricon fbricon force-pushed the macro_start_command_user_defined_ls branch 2 times, most recently from 7af8b5b to 9a97dff Compare June 11, 2024 16:16
@fbricon fbricon force-pushed the macro_start_command_user_defined_ls branch from 9a97dff to fc8f1a3 Compare June 11, 2024 16:18
@fbricon fbricon merged commit 620f36a into redhat-developer:main Jun 11, 2024
6 checks passed
@fbricon
Copy link
Contributor

fbricon commented Jun 11, 2024

Thanks @angelozerr!

@fbricon fbricon added enhancement New feature or request user-defined LS labels Jun 13, 2024
@fbricon fbricon added this to the 0.0.2 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-defined LS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support relative paths in the command and generate a config file in .idea that can be committed
2 participants