fix: Remove resource limits for manager container #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
requested review from
anandf,
iam-veeramalla and
ishitasequeira
and removed request for
jaideepr97 and
reginapizza
|
LGTM, Thanks @svghadi |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick v1.14 |
|
@svghadi: new pull request created: #784 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
During the operator-sdk upgrade, we set resource limits for the manager container. However, these limits are causing issues for users, particularly on clusters with a large number of secrets and configmaps, as the operator requires significantly more memory to function, leading to OOM kills. We are currently exploring ways to reduce memory consumption, however, this involves significant effort. Therefore, this PR removes the limits to minimize the impact.
Which issue(s) this PR fixes:
Fixes GITOPS-5665
How to test changes / Special notes to the reviewer:
I have tested this change using the reproducer from JIRA. The operator was functioning properly, consuming over 2GB of memory without any OOM kills.