Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub check to ensure consistency of generated manifests #738

Merged

Conversation

jgwest
Copy link
Collaborator

@jgwest jgwest commented Jun 14, 2024

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:

  • Add a new GitHub action to verify that PR contributors have run make manifests make bundle and make manifests and contributed the result.
  • This works with the changes made previously to ensure operator-sdk version is as expected.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Copy link

openshift-ci bot commented Jun 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest jgwest marked this pull request as ready for review June 14, 2024 02:55
@openshift-ci openshift-ci bot requested review from sbose78 and wtam2018 June 14, 2024 02:55
@jgwest
Copy link
Collaborator Author

jgwest commented Jun 18, 2024

/retest

@jgwest jgwest force-pushed the fail-on-generated-out-of-sync-june-2024 branch 2 times, most recently from 876de06 to c6e3411 Compare June 22, 2024 06:10
@jgwest
Copy link
Collaborator Author

jgwest commented Jun 25, 2024

/retest

@jgwest jgwest force-pushed the fail-on-generated-out-of-sync-june-2024 branch from c6e3411 to 3000ac0 Compare July 10, 2024 08:59
@jgwest jgwest requested review from jparsai and removed request for sbose78 and wtam2018 July 10, 2024 09:02
@jgwest jgwest force-pushed the fail-on-generated-out-of-sync-june-2024 branch from 3000ac0 to 7ef9aea Compare July 13, 2024 04:32
@jgwest
Copy link
Collaborator Author

jgwest commented Jul 15, 2024

/retest

@jparsai
Copy link
Collaborator

jparsai commented Jul 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 16, 2024
@jgwest jgwest force-pushed the fail-on-generated-out-of-sync-june-2024 branch from 7ef9aea to 4ad2fab Compare July 22, 2024 16:31
@openshift-ci openshift-ci bot removed the lgtm label Jul 22, 2024
Copy link

openshift-ci bot commented Jul 22, 2024

New changes are detected. LGTM label has been removed.

@jgwest jgwest force-pushed the fail-on-generated-out-of-sync-june-2024 branch from 4ad2fab to 33818f6 Compare July 22, 2024 16:40
@jgwest jgwest force-pushed the fail-on-generated-out-of-sync-june-2024 branch from 33818f6 to cc7c25f Compare July 22, 2024 17:33
@jgwest
Copy link
Collaborator Author

jgwest commented Jul 23, 2024

Merging as prow tests failures are not related.

@jgwest jgwest merged commit 8d8a242 into redhat-developer:master Jul 23, 2024
16 of 20 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants