Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix small typos in README and dex doc #666

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

hncrio
Copy link
Contributor

@hncrio hncrio commented Mar 19, 2024

What type of PR is this?

/kind documentation

What does this PR do / why we need it:
fix small typos in README and dex doc , no change in content

@openshift-ci openshift-ci bot added the kind/documentation Improvements or additions to documentation label Mar 19, 2024
@openshift-ci openshift-ci bot requested review from ciiay and iam-veeramalla March 19, 2024 13:03
Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jopit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 19, 2024

Hi @hncrio. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@svghadi
Copy link
Member

svghadi commented Apr 1, 2024

/ok-to-test

@svghadi
Copy link
Member

svghadi commented May 17, 2024

/lgtm

Thank you @hncrio !!

@openshift-ci openshift-ci bot added the lgtm label May 17, 2024
@svghadi svghadi changed the title fix small typos in README and dex doc doc: fix small typos in README and dex doc May 17, 2024
Copy link
Collaborator

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@jgwest jgwest merged commit df6c4d9 into redhat-developer:master Jun 27, 2024
8 of 9 checks passed
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation lgtm ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants