Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearer instruction to disable default argocd instance #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

makeittotop
Copy link

What type of PR is this?
/kind documentation

What does this PR do / why we need it:
Specifically mentioning to edit the env resource within the subscriptions.operators.coreos.com.spec.config CRD to add the associated env. var. in order to disable the default argocd instance launch.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Clearly mentioning the `env` resource within the `subscriptions.operators.coreos.com.spec.config` CRD to add the associated env. var. leading to disabling the default argocd  instance launch
@openshift-ci openshift-ci bot added the kind/documentation Improvements or additions to documentation label Dec 7, 2022
@openshift-ci openshift-ci bot requested review from chetan-rns and jgwest December 7, 2022 12:18
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jopit for approval by writing /assign @jopit in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2022

Hi @makeittotop. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iam-veeramalla
Copy link
Collaborator

ok-to-test

@varshab1210
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

@makeittotop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.8-kuttl-sequential ebfc639 link true /test v4.8-kuttl-sequential
ci/prow/v4.8-kuttl-parallel ebfc639 link true /test v4.8-kuttl-parallel
ci/prow/v4.9-kuttl-sequential ebfc639 link true /test v4.9-kuttl-sequential
ci/prow/v4.12-kuttl-parallel ebfc639 link true /test v4.12-kuttl-parallel
ci/prow/v4.12-kuttl-sequential ebfc639 link true /test v4.12-kuttl-sequential
ci/prow/v4.10-kuttl-parallel ebfc639 link true /test v4.10-kuttl-parallel
ci/prow/v4.10-kuttl-sequential ebfc639 link true /test v4.10-kuttl-sequential
ci/prow/v4.11-kuttl-sequential ebfc639 link true /test v4.11-kuttl-sequential
ci/prow/v4.13-kuttl-sequential ebfc639 link true /test v4.13-kuttl-sequential
ci/prow/v4.13-kuttl-parallel ebfc639 link true /test v4.13-kuttl-parallel
ci/prow/v4.13-e2e ebfc639 link true /test v4.13-e2e
ci/prow/v4.14-kuttl-sequential-periodic ebfc639 link true /test v4.14-kuttl-sequential-periodic
ci/prow/v4.14-kuttl-sequential ebfc639 link true /test v4.14-kuttl-sequential
ci/prow/v4.14-kuttl-parallel ebfc639 link true /test v4.14-kuttl-parallel
ci/prow/v4.14-e2e ebfc639 link true /test v4.14-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@saumeya
Copy link
Member

saumeya commented Sep 4, 2024

@makeittotop I know it is an old PR but can you rebase this ?

@makeittotop
Copy link
Author

makeittotop commented Sep 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants