Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify 'dotnet-ef' version for tools-in-path #319

Merged
merged 1 commit into from
Nov 17, 2023
Merged

specify 'dotnet-ef' version for tools-in-path #319

merged 1 commit into from
Nov 17, 2023

Conversation

nicrowe00
Copy link
Contributor

With the release of .NET 8, the tools for .NET have also been updated for .NET 8. The new updated tools are incompatiable with .NET 6 and 7 meaning the correct tool version must be specified for the version of .NET installed on the machine.

@nicrowe00
Copy link
Contributor Author

The test for .NET 8 on Fedora 38 is failing as the new release of .NET 8 still isn't available in the package manager for Fedora which causes it to use .NET 8-rc2 which is incompatible with the new update for 'dotnet-ef'. This test will continue to fail until new release of .NET 8 is added to the Fedora package manager.

@nicrowe00
Copy link
Contributor Author

@tmds @omajid PTAL

@nicrowe00 nicrowe00 requested review from omajid and tmds November 17, 2023 12:10
@tmds
Copy link
Member

tmds commented Nov 17, 2023

Can you try what happens if we replace the whole if .. fi block with:

IFS='.-' read -ra VERSION_SPLIT <<< "$1" 

dotnet tool update -g dotnet-ef --version "${VERSION_SPLIT[0]}.*-*"

@tmds
Copy link
Member

tmds commented Nov 17, 2023

The new updated tools are incompatiable with .NET 6 and 7

For reference: dotnet/sdk#36904

@tmds tmds changed the title specify 'dotnet-et' version for tools-in-path specify 'dotnet-ef' version for tools-in-path Nov 17, 2023
tools-in-path/test.sh Outdated Show resolved Hide resolved
With the release of .NET 8, the tools for .NET have also been
updated for .NET 8. The new updated tools are incompatiable with .NET 6
and 7 meaning the correct tool version must be specified for the version
of .NET installed on the machine.
Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nicrowe00 nicrowe00 merged commit d3d39e7 into redhat-developer:main Nov 17, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants