Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip Zipkin traces for plugin registry #1109

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

svor
Copy link
Contributor

@svor svor commented Oct 11, 2024

What does this PR do?

Don't send traces to Zipkin when extensions are installing. The logs in the plugin registry pod are now clearer and more readable:

screenshot-github.aaakk.us.kg-2024_10_10-16_08_44

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7257

Release Notes

Docs PR (if applicable)

Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor self-assigned this Oct 11, 2024
@svor svor requested review from ibuziuk and SDawley as code owners October 11, 2024 09:23
@svor svor merged commit 5e04665 into devspaces-3-rhel-8 Oct 16, 2024
4 checks passed
@svor svor deleted the sv-no-zipkin branch October 16, 2024 08:35
@devstudio-release
Copy link
Contributor

Build 3.18 :: pluginregistry_3.x/335: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.18 :: pluginregistry_3.x/335: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7826 triggered

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.18 :: copyIIBsToQuay/2854: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.18 :: sync-to-downstream_3.x/7827: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7839 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link
Contributor

Build 3.18 :: operator-bundle_3.x/3665: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7827 triggered

@devstudio-release
Copy link
Contributor

Build 3.18 :: dsc_3.x/2025: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

Build 3.18 :: update-digests_3.x/7778: SUCCESS

Detected new images: rebuild operator-bundle
* pluginregistry; /DS_CI/operator-bundle_3.x/3665 triggered

@devstudio-release
Copy link
Contributor

Build 3.18 :: dsc_3.x/2025: SUCCESS

3.18.0-CI

@devstudio-release
Copy link
Contributor

Build 3.18 :: copyIIBsToQuay/2854: SUCCESS

3.18
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.18-16
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ crwjen-3 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.18-v4.17-840233- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.17-840233- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.17-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.16-840231- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.16-840231- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.15-840230- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.15-840230- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.14-840229- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.14-840229- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.13-840228- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.13-840228- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.18-v4.12-840247- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.18-v4.12-840247- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.18-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.18-v4.17-840233- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.17-840233- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.17-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.16-840231- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.16-840231- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.15-840230- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.15-840230- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.14-840229- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.14-840229- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.13-841657- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.13-841657- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.18-v4.12-841662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.18-v4.12-841662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.18-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.18-v4.17-840233- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.17-840233- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.17-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.16-840231- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.16-840231- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.15-840230- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.15-840230- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.14-840229- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.14-840229- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.13-841657- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.13-841657- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.18-v4.12-841662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.18-v4.12-841662- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.18-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants