Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set fixed versions for vsix extensions #1062

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

svor
Copy link
Contributor

@svor svor commented Mar 29, 2024

What does this PR do?

  • Set fixed versions for vsix extensions that are going to be included into the embedded plugin registry;
  • Add a script that can update extensions' versions to the latest compatible from opensx.org
  • Add GitHub workflow to check new vsix versions and create a PR if new versions exist
openvsx-sync.json
[
  {
    "id": "donjayamanne.githistory",
    "version": "0.6.20"
  },
  {
    "id": "yzane.markdown-pdf",
    "version": "1.5.0"
  },
  {
    "id": "DavidAnson.vscode-markdownlint",
    "version": "0.54.0"
  },
  {
    "id": "robocorp.robotframework-lsp",
    "version": "1.11.0"
  },
  {
    "id": "shardulm94.trailing-spaces",
    "version": "0.4.1"
  },
  {
    "id": "adamhartford.vscode-base64",
    "version": "0.1.0"
  },
...

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4116

@svor svor changed the title feat: set fixed versions for vsix extensions; add script to update ve… feat: set fixed versions for vsix extensions Mar 29, 2024
@svor
Copy link
Contributor Author

svor commented Apr 2, 2024

With this PR we are going to set fixed versions for all extensions (currently they are latest versions that are compatible with latest che-code version), they won't be updated automatically unless someone updates them by hands or running update_extensions_versions.sh script. It was done to support our own build of extensions with fixed versions in https://github.com/redhat-developer/devspaces-vscode-extensions/tree/devspaces-3-rhel-8 (to be done by https://issues.redhat.com/browse/CRW-4859).

What it gives:

cc @ibuziuk @SDawley @mkuznyetsov

@svor svor marked this pull request as ready for review April 2, 2024 11:55
@svor svor requested review from ibuziuk and SDawley as code owners April 2, 2024 11:55
@svor svor requested a review from mkuznyetsov April 2, 2024 11:55
vsixName=$1
# check the versions page is empty and retry if it is
for j in 1 2 3 4 5
do
for j in 1 2 3 4 5; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 5 ?

Copy link
Contributor Author

@svor svor Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes it fails to get extension's metadata from the openvsx because the internet is unreliable or problem with the openvsx.org server, here we retry to read it 5 times. If it fails 5 times, the script show an error

@SDawley
Copy link
Collaborator

SDawley commented Apr 2, 2024

The update script for the devspaces-vscode-extensions half of things will have to be updated so it doesn't run the download_vsix script.

@svor
Copy link
Contributor Author

svor commented Apr 2, 2024

The update script for the devspaces-vscode-extensions half of things will have to be updated so it doesn't run the download_vsix script.

yes and we'd need to revisit devspaces-vscode-extensions to add more extensions, because it doesn't have the whole list of embedded extensions at this moment.
For existing extensions in devspaces-vscode-extensions, we need to check if the source code revision provides appropriate extension's version. I didn't find a way how we can reference extension's version declared in openvsx.org and extension's source code with the same version.

svor added 6 commits April 4, 2024 17:59
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
@svor
Copy link
Contributor Author

svor commented Apr 5, 2024

New GH action was added to check new vsix versions and create a PR if new versions exist. This action should be executed on the 1st day of each month

@svor
Copy link
Contributor Author

svor commented Apr 10, 2024

@SDawley could you please have another look at this PR. If there are no concerns I'd like to merge this PR and continue work on https://github.com/redhat-developer/devspaces-vscode-extensions part

@svor svor merged commit a4f79a1 into devspaces-3-rhel-8 Apr 16, 2024
6 checks passed
@svor svor deleted the sv-extensions-versions branch April 16, 2024 12:36
@devstudio-release
Copy link
Contributor

Build 3.14 :: pluginregistry_3.x/304: Console, Changes, Git Data

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.14 :: pluginregistry_3.x/304: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6520 triggered

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

@devstudio-release
Copy link
Contributor

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6481: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 60548450 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants