-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set fixed versions for vsix extensions #1062
Conversation
…rsions Signed-off-by: Valeriy Svydenko <[email protected]>
With this PR we are going to set fixed versions for all extensions (currently they are latest versions that are compatible with latest che-code version), they won't be updated automatically unless someone updates them by hands or running What it gives:
|
vsixName=$1 | ||
# check the versions page is empty and retry if it is | ||
for j in 1 2 3 4 5 | ||
do | ||
for j in 1 2 3 4 5; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 5 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes it fails to get extension's metadata from the openvsx because the internet is unreliable or problem with the openvsx.org server, here we retry to read it 5 times. If it fails 5 times, the script show an error
The update script for the devspaces-vscode-extensions half of things will have to be updated so it doesn't run the download_vsix script. |
dependencies/che-plugin-registry/build/scripts/download_vsix.sh
Outdated
Show resolved
Hide resolved
yes and we'd need to revisit devspaces-vscode-extensions to add more extensions, because it doesn't have the whole list of embedded extensions at this moment. |
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
New GH action was added to check new vsix versions and create a PR if new versions exist. This action should be executed on the 1st day of each month |
@SDawley could you please have another look at this PR. If there are no concerns I'd like to merge this PR and continue work on https://github.com/redhat-developer/devspaces-vscode-extensions part |
Build 3.14 :: pluginregistry_3.x/304: Console, Changes, Git Data |
Build 3.14 :: sync-to-downstream_3.x/6520: Console, Changes, Git Data |
Build 3.14 :: push-latest-container-to-quay_3.x/4540: Console, Changes, Git Data |
Build 3.14 :: get-sources-rhpkg-container-build_3.x/6476: pluginregistry : 3.x :: Build 60539369 : quay.io/devspaces/pluginregistry-rhel8:3.14-2 |
Build 3.14 :: pluginregistry_3.x/304: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6520 triggered |
Build 3.14 :: update-digests_3.x/6349: Console, Changes, Git Data |
Build 3.14 :: operator-bundle_3.x/2827: Console, Changes, Git Data |
Build 3.14 :: sync-to-downstream_3.x/6525: Console, Changes, Git Data |
Build 3.14 :: get-sources-rhpkg-container-build_3.x/6481: devspaces-operator-bundle : 3.x :: Failed in 60548450 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
openvsx-sync.json
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4116