fix: Fix build of the ms-vscode.js-debug extension #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
requested review from
svor,
ibuziuk and
SDawley
as code owners
svor
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I recommend specifying the full image name directly in the Dockerfile as follows:
FROM registry.access.redhat.com/ubi9/nodejs-20:9.5
instead of using the ubi8Image attribute in plugin-config.json. The reason is that you’re using a UBI9 image, but the attribute name still references UBI8, which can cause confusion.
In general I don't remember why devspaces-code uses this Dockerfile to build the extension. Probably @mkuznyetsov should know something about that.
RomanNikitenko
force-pushed
the
fix-ms-vscode-js-debug-build
branch
from
0d05985 to
fb8bad3
Compare
|
@svor |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: Roman Nikitenko <[email protected]>
RomanNikitenko
force-pushed
the
fix-ms-vscode-js-debug-build
branch
from
fb8bad3 to
907b033
Compare
SDawley
approved these changes
Dec 17, 2024
|
Should be devspaces-3-rhel-9 |
SDawley
changed the base branch from
devspaces-3-rhel-8
to
devspaces-3-rhel-9
SDawley
changed the base branch from
devspaces-3-rhel-9
to
devspaces-3-rhel-8
|
i think you need to make these changes for devspaces-3-rhel-9 and devspaces-3.18-rhel-9 |
svor
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build of the
ms-vscode.js-debugextension is failing with the following error:At the moment:
ubi8/nodejs-18:1-102is used to build the extension.ubi8/nodejs-18:1-102image contains GLIBC2.28ms-vscode.js-debugrequires GLIBC2.29I didn't find
ubi8-based image with the correspondingGLIBCversion,so I propose to try
ubi9-based image - it contains2.34version.